1324103 - clang-cl warning: 'mozilla::dom::DOMException::GetMessageMoz' hides overloaded virtual function

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Nathan Froyd [:froydnj]]

clang-cl complains thusly:

41:52.16 c:/m-c/obj64-clang-cl-optimized/dist/include\mozilla/dom/DOMException.h(178,8):  warning: 'mozilla::dom::DOMException::GetMessageMoz' hides overloaded virtual function [-Woverloaded-virtual]
41:52.16   void GetMessageMoz(nsString& retval);
41:52.16        ^
41:52.16 c:/m-c/obj64-clang-cl-optimized/dist/include\mozilla/dom/DOMException.h(58,3):  note: hidden overloaded virtual function 'mozilla::dom::Exception::GetMessageMoz' declared here: type mismatch at 1st parameter ('nsACString_internal &' vs 'nsString &')
41:52.16   NS_DECL_NSIEXCEPTION
41:52.16   ^
41:52.16 c:/m-c/obj64-clang-cl-optimized/dist/include\nsIException.h(299,14):  note: expanded from macro 'NS_DECL_NSIEXCEPTION'
41:52.16   NS_IMETHOD GetMessageMoz(nsACString & aMessage) override; \
41:52.16              ^

DOMException says "// Intentionally shadow the nsXPCException version"...I'm not sure what it's referring to there.  Would it make any difference if we just renamed the DOMException version?

Comment 1

[Boris Zbarsky [:bzbarsky]]

I think renaming is fine, since we're binarynaming here anyway.

Comment 2

[(Away)]

I don't see this warning anymore; presumably fixed by https://hg.mozilla.org/integration/mozilla-inbound/rev/3dc0da16efed