Closed Bug 1324106 Opened 8 years ago Closed 6 years ago

clang-cl warning: format specifies type 'unsigned int' but the argument has type 'size_t' (aka 'unsigned long long')

Categories

(Core :: Audio/Video: cubeb, defect, P4)

Product:
Core
Component:
Audio/Video: cubeb
Platform:
All
Windows
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: froydnj, Unassigned)

References

Details

clang-cl complains thusly:

14:43.08 c:/m-c/media/libcubeb/src/cubeb_wasapi.cpp(736,82):  warning: format specifies type 'unsigned int' but the argument has type 'size_t' (aka 'unsigned long long') [-Wformat]
14:43.08     LOG("padding silence: out=%f in=%f pad=%u", output_duration, input_duration, padding);
14:43.08                                            ~~                                    ^~~~~~~
14:43.08                                            %zu
14:43.08 c:/m-c/media/libcubeb/src/cubeb_log.h(29,61):  note: expanded from macro 'LOG'
14:43.08 #define LOG(msg, ...) LOG_INTERNAL(CUBEB_LOG_NORMAL, msg, ##__VA_ARGS__)
14:43.08                                                             ^~~~~~~~~~~
14:43.08 c:/m-c/media/libcubeb/src/cubeb_log.h(33,64):  note: expanded from macro 'LOG_INTERNAL'
14:43.08       g_log_callback("%s:%d: " fmt "\n", __FILE__, __LINE__, ##__VA_ARGS__); \
14:43.08                                                                ^~~~~~~~~~~

I'm not sure if we're permitted to use %zu in this case, though...
Rank: 35
Priority: -- → P3
Mass change P3->P4 to align with new Mozilla triage process.
Priority: P3 → P4
The offending code was removed in https://hg.mozilla.org/mozilla-central/rev/6befd9682522
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.