NSD_FreeImage called on wrong handle

RESOLVED INVALID

Status

()

Firefox
Installer
P5
normal
RESOLVED INVALID
11 months ago
3 months ago

People

(Reporter: agashlin, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

11 months ago
https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/browser/installer/windows/nsis/stub.nsi#861

https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/browser/installer/windows/nsis/stub.nsi#1405

These calls use $0, intending to free handles from lines 835 and 1322 respectively, but $0 has been clobbered in the meanwhile. This may result in a small memory leak.

Updated

11 months ago
Priority: -- → P5
This has been resolved by removing the intro screen; remaining NSD_FreeImage calls are made with a variable instead of a register, and there's only one image at a time for them to free.
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.