Closed Bug 1324117 Opened 5 years ago Closed 5 years ago
Enable APZ scrollbar dragging on Nightly
58 bytes, text/x-review-board-request
As mentioned in bug 1251617 comment 5, I think we're now in good enough shape to turn on APZ scrollbar dragging on the Nightly channel. We have a few remaining known issues (see dependencies of bug 1211610), but they are either hard to reproduce, or hard to fix. Enabling the feature and getting feedback from our Nightly user base will likely result in more testcases for the hard-to-reproduce bugs, and a sense of how severe the hard-to-fix bugs are.
Kevin, would you like to do the honours and flip the switch? It just involves modifying all.js to set the pref to true inside an #ifdef NIGHTLY_BUILD block. See  for an exmaple.  http://searchfox.org/mozilla-central/rev/f680e72cc6579f90b992b63ca14d923d2afea612/modules/libpref/init/all.js#671
Assignee: nobody → kevin.m.wern
(In reply to Botond Ballo [:botond] from comment #1) > Kevin, would you like to do the honours and flip the switch? It just > involves modifying all.js to set the pref to true inside an #ifdef > NIGHTLY_BUILD block. See  for an exmaple. > >  > http://searchfox.org/mozilla-central/rev/ > f680e72cc6579f90b992b63ca14d923d2afea612/modules/libpref/init/all.js#671 Done. Let's hope for the best :).
5 years ago
Priority: -- → P3
Comment on attachment 8819482 [details] Bug 1324117 - Enable APZ scrollbar dragging on Nightly https://reviewboard.mozilla.org/r/99234/#review99954
Attachment #8819482 - Flags: review?(botond) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/8615f78ac4f4 Enable APZ scrollbar dragging on Nightly r=botond
Thanks, Kevin! I announced the enablement on the dev-platform mailing list , so people know where to file bugs if they encounter any regressions.  https://groups.google.com/forum/#!topic/mozilla.dev.platform/_65Nu8PphT4
I had to back this out in https://hg.mozilla.org/integration/autoland/rev/90f2fd2c7ee34a6079c7fd3d8cd3f7ab32537eb1 for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=8124350&repo=autoland
My bad, I should have pushed to Try before landing. I filed bug 1324581 for fixing this test. Kevin, let me know if you're interested in working on it.
The Try push looks green, and I already landed bug 1324581. In order for me to re-land this patch using Autoland, you need to re-open the review request. Could you do so? There should be a "Reopen for Review" button at https://reviewboard.mozilla.org/r/99232/.
Just reopened it.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/d7518eef6b89 Enable APZ scrollbar dragging on Nightly r=botond
Amazing work, I'm glad to see this shipping :D! I had filed a serious blocker bug 1250649. I wonder if it's still an issue? needinfo me if you want any details.
Ohh I just re-read the announcement and it looks like it's still on radar. Sorry for the noise.
(In reply to Benoit Girard (:BenWa) from comment #14) > I had filed a serious blocker bug 1250649. I wonder if it's still an issue? > needinfo me if you want any details. We're looking for a URL that reproduces that issue. If you have one, please post it there.
I tried to reproduce this artificially and I couldn't. See the bug for more info. Good stuff!
Depends on: 1352863
4 years ago
Depends on: 1456638
You need to log in before you can comment on or make changes to this bug.