Closed Bug 1324117 Opened 3 years ago Closed 3 years ago

Enable APZ scrollbar dragging on Nightly

Categories

(Core :: Panning and Zooming, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: botond, Assigned: kevin.m.wern)

References

(Depends on 3 open bugs)

Details

(Keywords: perf, Whiteboard: [gfx-noted])

Attachments

(1 file)

As mentioned in bug 1251617 comment 5, I think we're now in good enough shape to turn on APZ scrollbar dragging on the Nightly channel.

We have a few remaining known issues (see dependencies of bug 1211610), but they are either hard to reproduce, or hard to fix. Enabling the feature and getting feedback from our Nightly user base will likely result in more testcases for the hard-to-reproduce bugs, and a sense of how severe the hard-to-fix bugs are.
Kevin, would you like to do the honours and flip the switch? It just involves modifying all.js to set the pref to true inside an #ifdef NIGHTLY_BUILD block. See [1] for an exmaple.

[1] http://searchfox.org/mozilla-central/rev/f680e72cc6579f90b992b63ca14d923d2afea612/modules/libpref/init/all.js#671
Assignee: nobody → kevin.m.wern
(In reply to Botond Ballo [:botond] from comment #1)
> Kevin, would you like to do the honours and flip the switch? It just
> involves modifying all.js to set the pref to true inside an #ifdef
> NIGHTLY_BUILD block. See [1] for an exmaple.
> 
> [1]
> http://searchfox.org/mozilla-central/rev/
> f680e72cc6579f90b992b63ca14d923d2afea612/modules/libpref/init/all.js#671

Done. Let's hope for the best :).
Comment on attachment 8819482 [details]
Bug 1324117 - Enable APZ scrollbar dragging on Nightly

https://reviewboard.mozilla.org/r/99234/#review99954
Attachment #8819482 - Flags: review?(botond) → review+
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8615f78ac4f4
Enable APZ scrollbar dragging on Nightly r=botond
Thanks, Kevin!

I announced the enablement on the dev-platform mailing list [1], so people know where to file bugs if they encounter any regressions.

[1] https://groups.google.com/forum/#!topic/mozilla.dev.platform/_65Nu8PphT4
My bad, I should have pushed to Try before landing.

I filed bug 1324581 for fixing this test. Kevin, let me know if you're interested in working on it.
Flags: needinfo?(kevin.m.wern)
The Try push looks green, and I already landed bug 1324581.

In order for me to re-land this patch using Autoland, you need to re-open the review request. Could you do so? There should be a "Reopen for Review" button at https://reviewboard.mozilla.org/r/99232/.
Flags: needinfo?(kevin.m.wern)
Just reopened it.
Flags: needinfo?(kevin.m.wern)
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7518eef6b89
Enable APZ scrollbar dragging on Nightly r=botond
https://hg.mozilla.org/mozilla-central/rev/d7518eef6b89
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Amazing work, I'm glad to see this shipping :D!

I had filed a serious blocker bug 1250649. I wonder if it's still an issue? needinfo me if you want any details.
Ohh I just re-read the announcement and it looks like it's still on radar. Sorry for the noise.
(In reply to Benoit Girard (:BenWa) from comment #14)
> I had filed a serious blocker bug 1250649. I wonder if it's still an issue?
> needinfo me if you want any details.

We're looking for a URL that reproduces that issue. If you have one, please post it there.
I tried to reproduce this artificially and I couldn't. See the bug for more info. Good stuff!
Depends on: 1328658
Depends on: 1331693
Depends on: 1346632
Depends on: 1355374
Depends on: 1355375
Depends on: 1355376
Depends on: 1355651
Depends on: 1357904
Depends on: 1366365
Depends on: 1378247
Depends on: 1422070
Depends on: 1438514
Depends on: 1439148
You need to log in before you can comment on or make changes to this bug.