Enable APZ scrollbar dragging on Nightly

RESOLVED FIXED in Firefox 53

Status

()

Core
Panning and Zooming
P3
normal
RESOLVED FIXED
11 months ago
5 months ago

People

(Reporter: botond, Assigned: Kevin Wern)

Tracking

({perf})

Trunk
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
As mentioned in bug 1251617 comment 5, I think we're now in good enough shape to turn on APZ scrollbar dragging on the Nightly channel.

We have a few remaining known issues (see dependencies of bug 1211610), but they are either hard to reproduce, or hard to fix. Enabling the feature and getting feedback from our Nightly user base will likely result in more testcases for the hard-to-reproduce bugs, and a sense of how severe the hard-to-fix bugs are.
(Reporter)

Comment 1

11 months ago
Kevin, would you like to do the honours and flip the switch? It just involves modifying all.js to set the pref to true inside an #ifdef NIGHTLY_BUILD block. See [1] for an exmaple.

[1] http://searchfox.org/mozilla-central/rev/f680e72cc6579f90b992b63ca14d923d2afea612/modules/libpref/init/all.js#671
Assignee: nobody → kevin.m.wern
Comment hidden (mozreview-request)
(Assignee)

Comment 3

11 months ago
(In reply to Botond Ballo [:botond] from comment #1)
> Kevin, would you like to do the honours and flip the switch? It just
> involves modifying all.js to set the pref to true inside an #ifdef
> NIGHTLY_BUILD block. See [1] for an exmaple.
> 
> [1]
> http://searchfox.org/mozilla-central/rev/
> f680e72cc6579f90b992b63ca14d923d2afea612/modules/libpref/init/all.js#671

Done. Let's hope for the best :).
Priority: -- → P3
(Reporter)

Comment 4

11 months ago
mozreview-review
Comment on attachment 8819482 [details]
Bug 1324117 - Enable APZ scrollbar dragging on Nightly

https://reviewboard.mozilla.org/r/99234/#review99954
Attachment #8819482 - Flags: review?(botond) → review+

Comment 5

11 months ago
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8615f78ac4f4
Enable APZ scrollbar dragging on Nightly r=botond
(Reporter)

Comment 6

11 months ago
Thanks, Kevin!

I announced the enablement on the dev-platform mailing list [1], so people know where to file bugs if they encounter any regressions.

[1] https://groups.google.com/forum/#!topic/mozilla.dev.platform/_65Nu8PphT4

Comment 7

11 months ago
I had to back this out in https://hg.mozilla.org/integration/autoland/rev/90f2fd2c7ee34a6079c7fd3d8cd3f7ab32537eb1 for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=8124350&repo=autoland
Flags: needinfo?(kevin.m.wern)
(Reporter)

Updated

11 months ago
Depends on: 1324581
(Reporter)

Comment 8

11 months ago
My bad, I should have pushed to Try before landing.

I filed bug 1324581 for fixing this test. Kevin, let me know if you're interested in working on it.
Flags: needinfo?(kevin.m.wern)
(Reporter)

Comment 9

11 months ago
Try push for this bug + bug 1324581: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b979d3f7d7821b94a21c104dfaf7f270b8dd439c
(Reporter)

Comment 10

11 months ago
The Try push looks green, and I already landed bug 1324581.

In order for me to re-land this patch using Autoland, you need to re-open the review request. Could you do so? There should be a "Reopen for Review" button at https://reviewboard.mozilla.org/r/99232/.
Flags: needinfo?(kevin.m.wern)
(Assignee)

Comment 11

11 months ago
Just reopened it.
Flags: needinfo?(kevin.m.wern)

Comment 12

11 months ago
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7518eef6b89
Enable APZ scrollbar dragging on Nightly r=botond

Comment 13

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d7518eef6b89
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Comment 14

11 months ago
Amazing work, I'm glad to see this shipping :D!

I had filed a serious blocker bug 1250649. I wonder if it's still an issue? needinfo me if you want any details.

Comment 15

11 months ago
Ohh I just re-read the announcement and it looks like it's still on radar. Sorry for the noise.
(Reporter)

Comment 16

11 months ago
(In reply to Benoit Girard (:BenWa) from comment #14)
> I had filed a serious blocker bug 1250649. I wonder if it's still an issue?
> needinfo me if you want any details.

We're looking for a URL that reproduces that issue. If you have one, please post it there.

Comment 17

11 months ago
I tried to reproduce this artificially and I couldn't. See the bug for more info. Good stuff!
Depends on: 1328658
Depends on: 1331693

Updated

9 months ago
Depends on: 1346632
Depends on: 1352863

Updated

8 months ago
Depends on: 1355374

Updated

8 months ago
Depends on: 1355375

Updated

8 months ago
Depends on: 1355376

Updated

8 months ago
Depends on: 1355651

Updated

7 months ago
Depends on: 1357904
(Reporter)

Updated

7 months ago
Depends on: 1359868

Updated

6 months ago
Depends on: 1366365

Updated

5 months ago
Depends on: 1378247
You need to log in before you can comment on or make changes to this bug.