Closed
Bug 1324135
Opened 7 years ago
Closed 7 years ago
Intermittent dom/base/test/test_intersectionobservers.html | triggers only once if observed multiple times (and does not crash when collected) [observe] - got +0, expected 1
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | fixed |
firefox55 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: tschneider)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])
Attachments
(2 files, 1 obsolete file)
Filed by: wkocher [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=8035054&repo=autoland https://queue.taskcluster.net/v1/task/Z-GM52PdSUecZsAcbmENMQ/runs/0/artifacts/public/logs/live_backing.log
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 6•7 years ago
|
||
ni myself to investigate a bit more
Flags: needinfo?(jmaher)
Whiteboard: [stockwell needswork]
Updated•7 years ago
|
Comment 7•7 years ago
|
||
this was related to bug 1321865, it was backed out as we had a ~perma fail in bug 1313972.
Whiteboard: [stockwell needswork] → [stockwell disabled]
Comment 8•7 years ago
|
||
Can this test be rewritten this way to remove the race? it('triggers only once if observed multiple times (and does not crash when collected)', function(done) { var spy = sinon.spy(); io = new IntersectionObserver(spy, {root: rootEl}); io.observe(targetEl1); io.observe(targetEl1); io.observe(targetEl1); spy.waitForNotification(function() { callDelayed(function () { expect(spy.callCount).to.be(1); done(); }, ASYNC_TIMEOUT); }, 0); });
Flags: needinfo?(tschneider)
Assignee | ||
Comment 10•7 years ago
|
||
Applies recommended change from Comment 8 plus removes unnecessary delay arguments.
Assignee | ||
Updated•7 years ago
|
Attachment #8858436 -
Flags: review?(bugs)
Assignee | ||
Comment 11•7 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=355bde69a024f29fe5eeb34ed1f91cf0cf2adc01
Comment 12•7 years ago
|
||
Comment on attachment 8858436 [details] [diff] [review] Fix intermittent test failure >@@ -918,10 +918,12 @@ limitations under the License. > io.observe(targetEl1); > io.observe(targetEl1); > >- callDelayed(function () { >- expect(spy.callCount).to.be(1); >- done(); >- }, ASYNC_TIMEOUT * 3); >+ spy.waitForNotification(function() { >+ callDelayed(function () { >+ expect(spy.callCount).to.be(1); >+ done(); >+ }, ASYNC_TIMEOUT); >+ }, 0); Lose the 0 here if that's your new convention. r+ with nits fixed and better commit message. Maybe: Wait 300ms after the first IntersectionObserver notification to prevent intermittent test failure.
Attachment #8858436 -
Flags: review?(bugs) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 14•7 years ago
|
||
Pushed by philringnalda@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/940919c5af90 Wait 300ms after the first IntersectionObserver notification to prevent intermittent test failure, r=jet
Keywords: checkin-needed
Updated•7 years ago
|
Assignee: nobody → tschneider
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/940919c5af90
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee | ||
Comment 16•7 years ago
|
||
Comment on attachment 8858491 [details] [diff] [review] Wait 300ms after the first IntersectionObserver notification to prevent intermittent test failure. Approval Request Comment [Feature/Bug causing the regression]: 1321865 [User impact if declined]: No test coverage [Is this code covered by automated tests?]: It is one [Has the fix been verified in Nightly?]: Yes [Is the change risky?]: No
Attachment #8858491 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 17•7 years ago
|
||
Comment on attachment 8858491 [details] [diff] [review] Wait 300ms after the first IntersectionObserver notification to prevent intermittent test failure. not part of the build
Attachment #8858491 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 18•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Whiteboard: [stockwell disabled] → [stockwell disabled] [checkin-needed-beta]
Updated•7 years ago
|
status-firefox53:
--- → unaffected
status-firefox54:
--- → affected
status-firefox-esr52:
--- → unaffected
Comment 19•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/b0a7956aa594
Flags: in-testsuite+
Whiteboard: [stockwell disabled] [checkin-needed-beta] → [stockwell fixed]
Comment hidden (Intermittent Failures Robot) |
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•