Intermittent dom/base/test/test_intersectionobservers.html | triggers only once if observed multiple times (and does not crash when collected) [observe] - got +0, expected 1

RESOLVED FIXED in Firefox 54

Status

()

Core
DOM
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: Treeherder Bug Filer, Assigned: tobytailor)

Tracking

({intermittent-failure})

unspecified
mozilla55
intermittent-failure
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 fixed, firefox55 fixed)

Details

(Whiteboard: [stockwell fixed])

Attachments

(2 attachments, 1 obsolete attachment)

Comment 1

a year ago
8 failures in 526 pushes (0.015 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 5
* autoland: 3

Platform breakdown:
* linux64: 6
* linux32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1324135&startday=2016-12-12&endday=2016-12-18&tree=all

Comment 2

a year ago
16 failures in 305 pushes (0.052 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 7
* autoland: 7
* mozilla-central: 2

Platform breakdown:
* linux32: 9
* linux64: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1324135&startday=2016-12-26&endday=2017-01-01&tree=all

Comment 3

a year ago
5 failures in 690 pushes (0.007 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 4
* mozilla-central: 1

Platform breakdown:
* linux32: 3
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1324135&startday=2017-01-16&endday=2017-01-22&tree=all
See Also: → bug 1313972

Comment 4

a year ago
20 failures in 185 pushes (0.108 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 6
* autoland: 6
* mozilla-central: 4
* try: 3
* oak: 1

Platform breakdown:
* linux64: 12
* linux32: 5
* osx-10-10: 2
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1324135&startday=2017-04-07&endday=2017-04-07&tree=all

Comment 5

a year ago
44 failures in 867 pushes (0.051 failures/push) were associated with this bug in the last 7 days. 

This is the #42 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-inbound: 18
* autoland: 11
* mozilla-central: 10
* try: 4
* oak: 1

Platform breakdown:
* linux64: 25
* linux32: 13
* osx-10-10: 4
* windows7-32-vm: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1324135&startday=2017-04-03&endday=2017-04-09&tree=all
ni myself to investigate a bit more
Flags: needinfo?(jmaher)
Whiteboard: [stockwell needswork]
this was related to bug 1321865, it was backed out as we had a ~perma fail in bug 1313972.
Whiteboard: [stockwell needswork] → [stockwell disabled]
Can this test be rewritten this way to remove the race?

      it('triggers only once if observed multiple times (and does not crash when collected)', function(done) {
        var spy = sinon.spy();
        io = new IntersectionObserver(spy, {root: rootEl});
        io.observe(targetEl1);
        io.observe(targetEl1);
        io.observe(targetEl1);

        spy.waitForNotification(function() {
          callDelayed(function () {
            expect(spy.callCount).to.be(1);
            done();
          }, ASYNC_TIMEOUT);
        }, 0);

      });
Flags: needinfo?(tschneider)
(Assignee)

Comment 9

a year ago
Yes, that would work.
Flags: needinfo?(tschneider)
(Assignee)

Comment 10

a year ago
Created attachment 8858436 [details] [diff] [review]
Fix intermittent test failure

Applies recommended change from Comment 8 plus removes unnecessary delay arguments.
(Assignee)

Updated

a year ago
Attachment #8858436 - Flags: review?(bugs)
Comment on attachment 8858436 [details] [diff] [review]
Fix intermittent test failure


>@@ -918,10 +918,12 @@ limitations under the License.
>         io.observe(targetEl1);
>         io.observe(targetEl1);
> 
>-        callDelayed(function () {
>-          expect(spy.callCount).to.be(1);
>-          done();
>-        }, ASYNC_TIMEOUT * 3);
>+        spy.waitForNotification(function() {
>+          callDelayed(function () {
>+            expect(spy.callCount).to.be(1);
>+            done();
>+          }, ASYNC_TIMEOUT);
>+        }, 0);

Lose the 0 here if that's your new convention.

r+ with nits fixed and better commit message. Maybe:

Wait 300ms after the first IntersectionObserver notification to prevent intermittent test failure.
Attachment #8858436 - Flags: review?(bugs) → review+
(Assignee)

Comment 13

a year ago
Created attachment 8858491 [details] [diff] [review]
Wait 300ms after the first IntersectionObserver notification to prevent intermittent test failure.

Nits.
Attachment #8858436 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 14

a year ago
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/940919c5af90
Wait 300ms after the first IntersectionObserver notification to prevent intermittent test failure, r=jet
Keywords: checkin-needed
Assignee: nobody → tschneider
https://hg.mozilla.org/mozilla-central/rev/940919c5af90
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Comment 16

a year ago
Comment on attachment 8858491 [details] [diff] [review]
Wait 300ms after the first IntersectionObserver notification to prevent intermittent test failure.

Approval Request Comment
[Feature/Bug causing the regression]: 1321865
[User impact if declined]: No test coverage
[Is this code covered by automated tests?]: It is one
[Has the fix been verified in Nightly?]: Yes
[Is the change risky?]: No
Attachment #8858491 - Flags: approval-mozilla-beta?
(Assignee)

Comment 17

a year ago
Comment on attachment 8858491 [details] [diff] [review]
Wait 300ms after the first IntersectionObserver notification to prevent intermittent test failure.

not part of the build
Attachment #8858491 - Flags: approval-mozilla-beta?
(Assignee)

Comment 18

a year ago
Created attachment 8864630 [details] [diff] [review]
Patch for beta uplift
(Assignee)

Updated

a year ago
Blocks: 1362168
(Assignee)

Updated

a year ago
Whiteboard: [stockwell disabled] → [stockwell disabled] [checkin-needed-beta]
status-firefox53: --- → unaffected
status-firefox54: --- → affected
status-firefox-esr52: --- → unaffected

Comment 19

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/b0a7956aa594
status-firefox54: affected → fixed
Flags: in-testsuite+
Whiteboard: [stockwell disabled] [checkin-needed-beta] → [stockwell fixed]

Comment 20

10 months ago
1 failures in 814 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 1

Platform breakdown:
* android-4-3-armv7-api15: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1324135&startday=2017-06-12&endday=2017-06-18&tree=all
You need to log in before you can comment on or make changes to this bug.