BlitFramebuffer compares dst depth/stencil formats against srcColorFormat

RESOLVED FIXED in Firefox 51

Status

()

defect
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 disabled, firefox51 fixed, firefox52 fixed, firefox53 fixed)

Details

(Whiteboard: gfx-noted)

Attachments

(1 attachment)

This causes BlitFramebuffer with COLOR|DEPTH to fail, for instance.
Summary: BlitFramebuffer compares src depth/stencil formats against dstColorFormat → BlitFramebuffer compares dst depth/stencil formats against srcColorFormat
Attachment #8819485 - Flags: review?(cleu)
Comment on attachment 8819485 [details]
Bug 1324157 - Check dst colorDrawBuffers against src in BlitFramebuffer. -

https://reviewboard.mozilla.org/r/99238/#review99576
Attachment #8819485 - Flags: review?(cleu) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/78aafdccfc44
Check dst colorDrawBuffers against src in BlitFramebuffer. - r=lenzak800
https://hg.mozilla.org/mozilla-central/rev/78aafdccfc44
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8819485 [details]
Bug 1324157 - Check dst colorDrawBuffers against src in BlitFramebuffer. -

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:
Attachment #8819485 - Flags: approval-mozilla-beta?
Attachment #8819485 - Flags: approval-mozilla-aurora?
Comment on attachment 8819485 [details]
Bug 1324157 - Check dst colorDrawBuffers against src in BlitFramebuffer. -

Fix a WebGL 2 related issue. Beta51+ and Aurora52+. Should be in 51 beta 10.
Attachment #8819485 - Flags: approval-mozilla-beta?
Attachment #8819485 - Flags: approval-mozilla-beta+
Attachment #8819485 - Flags: approval-mozilla-aurora?
Attachment #8819485 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.