1324157 - BlitFramebuffer compares dst depth/stencil formats against srcColorFormat

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Kelsey Gilbert [:jgilbert]]

This causes BlitFramebuffer with COLOR|DEPTH to fail, for instance.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1324157 - Check dst colorDrawBuffers against src in BlitFramebuffer. -

Review commit: https://reviewboard.mozilla.org/r/99238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99238/

Comment 2

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8819485 [details]
Bug 1324157 - Check dst colorDrawBuffers against src in BlitFramebuffer. -

https://reviewboard.mozilla.org/r/99238/#review99576

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/78aafdccfc44
Check dst colorDrawBuffers against src in BlitFramebuffer. - r=lenzak800

Comment 4

[Kelsey Gilbert [:jgilbert]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1fa92284bc685cc65ccfea2ae3556788df6a0d55

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/78aafdccfc44

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8819485 [details]
Bug 1324157 - Check dst colorDrawBuffers against src in BlitFramebuffer. -

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8819485 [details]
Bug 1324157 - Check dst colorDrawBuffers against src in BlitFramebuffer. -

Fix a WebGL 2 related issue. Beta51+ and Aurora52+. Should be in 51 beta 10.

Comment 8

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/171be6aaa16e

Comment 9

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b5ef91442c0a