Closed Bug 1324174 Opened 8 years ago Closed 7 years ago

Simplify context management logic in nsSVGIntegrationUtils::PaintMask

Categories

(Core :: Web Painting, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: u459114, Assigned: u459114)

Details

Attachments

(1 file)

A follow up according to Bug 1313276 comment 4:
The context state management (what matrix is applied, what clips are applied) in the PaintMask function is getting a little hairy. It's fine for now but it seems easy to get wrong if somebody wants to add anything to the function. It would be nice to find a way to clean it up at some point.
Attachment #8822477 - Flags: review?(mstange)
Comment on attachment 8822477 [details]
Bug 1324174 - Simplify context management logic in nsSVGIntegrationUtils::PaintMask.

https://reviewboard.mozilla.org/r/101390/#review102042
Attachment #8822477 - Flags: review?(mstange) → review+
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88ab9fde6a04
Simplify context management logic in nsSVGIntegrationUtils::PaintMask. r=mstange
https://hg.mozilla.org/mozilla-central/rev/88ab9fde6a04
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: