Simplify context management logic in nsSVGIntegrationUtils::PaintMask

RESOLVED FIXED in Firefox 53

Status

()

Core
Layout: View Rendering
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: u459114, Assigned: u459114)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
A follow up according to Bug 1313276 comment 4:
The context state management (what matrix is applied, what clips are applied) in the PaintMask function is getting a little hairy. It's fine for now but it seems easy to get wrong if somebody wants to add anything to the function. It would be nice to find a way to clean it up at some point.
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8822477 - Flags: review?(mstange)

Comment 2

a year ago
mozreview-review
Comment on attachment 8822477 [details]
Bug 1324174 - Simplify context management logic in nsSVGIntegrationUtils::PaintMask.

https://reviewboard.mozilla.org/r/101390/#review102042
Attachment #8822477 - Flags: review?(mstange) → review+

Comment 3

a year ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88ab9fde6a04
Simplify context management logic in nsSVGIntegrationUtils::PaintMask. r=mstange

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/88ab9fde6a04
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.