Closed
Bug 1324178
Opened 8 years ago
Closed 7 years ago
WebIDL codegen doesn't catch invalid arguments (e.g. non-optional trailing dictionaries) in constructors
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
IDLInterfaceOrNamespace.validate never calls validate() on the constructor.
|
Assignee | |
Comment 1•8 years ago
|
||
Of course once I add those calls there are various interfaces in our tree that have invalid constructors!
|
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8819514 -
Flags: review?(amarchesini)
|
||
Updated•8 years ago
|
Attachment #8819514 -
Flags: review?(amarchesini) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1e631a95c4bc Actually enforce the various checks the IDL spec says to do for arguments of constructors and named constructors. r=baku
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1e631a95c4bc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•