Closed Bug 1324184 Opened 6 years ago Closed 6 years ago

Enable "no-tabs", "no-template-curly-in-string" and "quotes" ESLint rules for PSM

Categories

(Core :: Security: PSM, defect, P1)

Product:
Core
Component:
Security: PSM
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Details

(Whiteboard: [psm-assigned])

Attachments

(2 files)

Bug 1324184 - Stop using deprecated rules in PSM ESLint config.
58 bytes, text/x-review-board-request
keeler
: review+
Details
Bug 1324184 - Enable "no-tabs", "no-template-curly-in-string" and "quotes" ESLint rules for PSM.
58 bytes, text/x-review-board-request
keeler
: review+
Details 
"no-tabs" and "quotes" are only for enforcing PSM style, while "no-template-curly-in-string" is useful for catching actual errors.
Comment on attachment 8820317 [details]
Bug 1324184 - Stop using deprecated rules in PSM ESLint config.

https://reviewboard.mozilla.org/r/99832/#review100438
Attachment #8820317 - Flags: review?(dkeeler) → review+
Comment on attachment 8820318 [details]
Bug 1324184 - Enable "no-tabs", "no-template-curly-in-string" and "quotes" ESLint rules for PSM.

https://reviewboard.mozilla.org/r/99834/#review100440

Great - r=me.
Attachment #8820318 - Flags: review?(dkeeler) → review+
Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2856287b145560823a26a2efb6fd6e3039eaaad1
(Orange X(10) looks like an intermittent.)
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8cfe0d2b6a60
Stop using deprecated rules in PSM ESLint config. r=keeler
https://hg.mozilla.org/integration/autoland/rev/62c0fad31e2c
Enable "no-tabs", "no-template-curly-in-string" and "quotes" ESLint rules for PSM. r=keeler
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8cfe0d2b6a60
https://hg.mozilla.org/mozilla-central/rev/62c0fad31e2c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.