1324224 - bad use of plurals in mailnews/base/content/newmailalert.js

Status: RESOLVED FIXED

(MailNews Core :: Localization, defect)

Description

[:aceman]

The strings as newMailNotification_message in mailnews/base/content/newmailalert.js assome there are only 2 plural forms (of the English type).
Let's improve it with PluralForm.jsm

There are several variants of this new mail dialog in various *Integrations.cpp files with this string problem, but in C++ we do not yet have a way to handle plural forms (but surely we could implement the JS code of PluralForm.jsm in C++ once needed).

Comment 1

[:aceman]

Attachment: patch

I cannot remove the original strings, as they are still in use by the C++ variant of the dialog.

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 8819561 [details] [diff] [review]
patch

LGTM.

One question, when is the C++ version used?

Comment 3

[:aceman]

The comment at https://dxr.mozilla.org/comm-central/rev/5a163ed948ceb5e930d754a6491599d12471d94a/mailnews/base/src/nsMessengerUnixIntegration.cpp#334 claims there are libnotify version of the alert and our internal one. There are also c++ versions of the alert specific for Windows on OS X (e.g. https://dxr.mozilla.org/comm-central/rev/5a163ed948ceb5e930d754a6491599d12471d94a/mailnews/base/src/nsMessengerOSXIntegration.mm#299).

At least the Linux version is toggled by a bool pref mail.biff.use_system_alert .

Comment 4

[Philip Chee]

Comment on attachment 8819561 [details] [diff] [review]
patch

rs=me thanks

Comment 5

[:aceman]

Thanks.

Comment 6

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/764af75d8f8cb66b4a998979a47dc19056eadf3e