bad use of plurals in mailnews/base/content/newmailalert.js

RESOLVED FIXED in Thunderbird 53.0

Status

MailNews Core
Localization
--
trivial
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 53.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

5.49 KB, patch
Paenglab
: review+
Philip Chee
: review+
Details | Diff | Splinter Review
(Assignee)

Description

10 months ago
The strings as newMailNotification_message in mailnews/base/content/newmailalert.js assome there are only 2 plural forms (of the English type).
Let's improve it with PluralForm.jsm

There are several variants of this new mail dialog in various *Integrations.cpp files with this string problem, but in C++ we do not yet have a way to handle plural forms (but surely we could implement the JS code of PluralForm.jsm in C++ once needed).
(Assignee)

Comment 1

10 months ago
Created attachment 8819561 [details] [diff] [review]
patch

I cannot remove the original strings, as they are still in use by the C++ variant of the dialog.
Attachment #8819561 - Flags: review?(richard.marti)
Attachment #8819561 - Flags: review?(philip.chee)
Comment on attachment 8819561 [details] [diff] [review]
patch

LGTM.

One question, when is the C++ version used?
Attachment #8819561 - Flags: review?(richard.marti) → review+
(Assignee)

Comment 3

10 months ago
The comment at https://dxr.mozilla.org/comm-central/rev/5a163ed948ceb5e930d754a6491599d12471d94a/mailnews/base/src/nsMessengerUnixIntegration.cpp#334 claims there are libnotify version of the alert and our internal one. There are also c++ versions of the alert specific for Windows on OS X (e.g. https://dxr.mozilla.org/comm-central/rev/5a163ed948ceb5e930d754a6491599d12471d94a/mailnews/base/src/nsMessengerOSXIntegration.mm#299).

At least the Linux version is toggled by a bool pref mail.biff.use_system_alert .

Comment 4

10 months ago
Comment on attachment 8819561 [details] [diff] [review]
patch

rs=me thanks
Attachment #8819561 - Flags: review?(philip.chee) → review+
(Assignee)

Comment 5

10 months ago
Thanks.
Keywords: checkin-needed

Comment 6

10 months ago
https://hg.mozilla.org/comm-central/rev/764af75d8f8cb66b4a998979a47dc19056eadf3e
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0

Updated

10 months ago
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.