The strings as newMailNotification_message in mailnews/base/content/newmailalert.js assome there are only 2 plural forms (of the English type). Let's improve it with PluralForm.jsm There are several variants of this new mail dialog in various *Integrations.cpp files with this string problem, but in C++ we do not yet have a way to handle plural forms (but surely we could implement the JS code of PluralForm.jsm in C++ once needed).
Created attachment 8819561 [details] [diff] [review] patch I cannot remove the original strings, as they are still in use by the C++ variant of the dialog.
Comment on attachment 8819561 [details] [diff] [review] patch LGTM. One question, when is the C++ version used?
The comment at https://dxr.mozilla.org/comm-central/rev/5a163ed948ceb5e930d754a6491599d12471d94a/mailnews/base/src/nsMessengerUnixIntegration.cpp#334 claims there are libnotify version of the alert and our internal one. There are also c++ versions of the alert specific for Windows on OS X (e.g. https://dxr.mozilla.org/comm-central/rev/5a163ed948ceb5e930d754a6491599d12471d94a/mailnews/base/src/nsMessengerOSXIntegration.mm#299). At least the Linux version is toggled by a bool pref mail.biff.use_system_alert .
Comment on attachment 8819561 [details] [diff] [review] patch rs=me thanks