1324242 - Build failure with clang 3.9 and --enable-warnings-as-errors in gmock-internal-utils.h

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

4:27.17 In file included from Unified_cpp_tests_gtest0.cpp:2:
 4:27.17 In file included from /Users/ehsan/moz/src.landing/devtools/shared/heapsnapshot/tests/gtest/DeserializedNodeUbiNodes.cpp:10:
 4:27.17 In file included from ../../../../../../devtools/shared/heapsnapshot/tests/gtest/DevTools.h:15:
 4:27.17 In file included from ../../../../../dist/include/gmock/gmock.h:58:
 4:27.18 In file included from ../../../../../dist/include/gmock/gmock-actions.h:46:
 4:27.18 ../../../../../dist/include/gmock/internal/gmock-internal-utils.h:355:10: error: binding dereferenced null pointer to reference has undefined behavior [-Werror,-Wnull-dereference]
 4:27.18   return *static_cast<typename remove_reference<T>::type*>(NULL);
 4:27.18          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 4:27.18 ../../../../../dist/include/gmock/gmock-actions.h:78:22: note: in instantiation of function template specialization 'testing::internal::Invalid<JS::ubi::Node>' requested here
 4:27.18     return internal::Invalid<T>();
 4:27.18                      ^
 4:27.18 ../../../../../dist/include/gmock/gmock-actions.h:190:43: note: in instantiation of member function 'testing::internal::BuiltInDefaultValue<JS::ubi::Node>::Get' requested here
 4:27.18         internal::BuiltInDefaultValue<T>::Get() : *value_;
 4:27.18                                           ^
 4:27.18 ../../../../../dist/include/gmock/gmock-spec-builders.h:1437:34: note: in instantiation of member function 'testing::DefaultValue<JS::ubi::Node>::Get' requested here
 4:27.18     return DefaultValue<Result>::Get();
 4:27.18                                  ^
 4:27.18 ../../../../../dist/include/gmock/gmock-spec-builders.h:1334:22: note: in instantiation of member function 'testing::internal::FunctionMockerBase<JS::ubi::Node (const mozilla::devtools::DeserializedEdge &)>::PerformDefaultAction' requested here
 4:27.18         func_mocker->PerformDefaultAction(args, call_description));
 4:27.18                      ^
 4:27.18 ../../../../../dist/include/gmock/gmock-spec-builders.h:1450:26: note: in instantiation of function template specialization 'testing::internal::ActionResultHolder<JS::ubi::Node>::PerformDefaultAction<JS::ubi::Node (const mozilla::devtools::DeserializedEdge &)>' requested here
 4:27.18     return ResultHolder::PerformDefaultAction(this, args, call_description);
 4:27.18                          ^
 4:27.18 /Users/ehsan/moz/src.landing/devtools/shared/heapsnapshot/tests/gtest/DeserializedNodeUbiNodes.cpp:20:3: note: in instantiation of member function 'testing::internal::FunctionMockerBase<JS::ubi::Node (const mozilla::devtools::DeserializedEdge &)>::UntypedPerformDefaultAction' requested here
 4:27.18   MockDeserializedNode(NodeId id, const char16_t* typeName, uint64_t size)
 4:27.18   ^
 4:27.18 1 error generated.
 4:27.18


We need another workaround for bug 1142396.

Comment 1

[(no longer active)]

Attachment: Ignore the -Wnull-dereference warning caused by gtest

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c3dadb99d3e
Ignore the -Wnull-dereference warning caused by gtest; r=froydnj

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7c3dadb99d3e