1324244 - "http://" is not a valid URL

Status: RESOLVED DUPLICATE of bug 1275746

(Core :: Networking, defect)

Description

[Manish Goregaokar [:manishearth]]

We currently parse "http://" and "ftp://" as valid URLs. They are not.

See https://url.spec.whatwg.org/#hostname-state, special schemes (https://url.spec.whatwg.org/#special-scheme) cannot have empty hosts.

Chrome agrees with the spec here.

Comment 1

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1324244 - Stop parsing empty host/path URIs for special schemes as valid;

Review commit: https://reviewboard.mozilla.org/r/99364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99364/

Comment 2

[Manish Goregaokar [:manishearth]]

I'm not sure if this is the right place to do this check, or if I should do it in nsURLParsers.cpp. nsURLParsers.cpp seems to be a bit more general.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

We tried to fix this a few months ago, but it got backed out because it triggered a regression in the HTML form validator.
I'll try to land it as soon as the form bug gets fixed.

Comment 4

[Manish Goregaokar [:manishearth]]

Comment on attachment 8819695 [details]
Bug 1324244 - Stop parsing empty host/path URIs for special schemes as valid;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99364/diff/1-2/