Closed
Bug 1324256
Opened 7 years ago
Closed 7 years ago
Scrollbars too fat with Greybird OS theme
Categories
(Core :: Widget: Gtk, defect, P4)
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox51 | --- | unaffected |
firefox52 | --- | fixed |
firefox53 | --- | fixed |
People
(Reporter: kevink9876543, Assigned: karlt)
References
Details
(Keywords: regression, Whiteboard: tpi:+)
Attachments
(3 files)
102.05 KB,
image/png
|
Details | |
247.71 KB,
image/png
|
Details | |
59 bytes,
text/x-review-board-request
|
jhorak
:
review+
jcristau
:
approval-mozilla-aurora+
|
Details |
Firefox 52.0a2 build 20161216101750, or Firefox 53.0a1 build 20161217030205 Lubuntu 14.04 64-bit Greybird OS theme (GTK theme) STR: new Firefox profile 1) start Firefox 2) look at a scrollbar thumb Expected results: scrollbar thumb looks normal Actual results: scrollbar thumb looks really fat and takes up the entire track. In Greybird, the thumb is supposed to be centered on the track with some space on either side. Firefox 51.0b8 displays the scrollbar correctly.
Updated•7 years ago
|
Priority: -- → P4
Whiteboard: tpi:+
Assignee | ||
Comment 1•7 years ago
|
||
Are you able to attach screenshots, please, and comment on how the Greybird OS theme came to be used? e.g. is Greybird OS the default theme for LXDE?
Assignee | ||
Updated•7 years ago
|
Keywords: regression
Reporter | ||
Comment 2•7 years ago
|
||
Greybird is the default OS theme for Xubuntu 16.04, where I can also reproduce the issue. I like the Greybird theme and use it on Lubuntu as well. I will attach screenshots in a moment.
Reporter | ||
Comment 3•7 years ago
|
||
Reporter | ||
Comment 4•7 years ago
|
||
Assignee | ||
Comment 5•7 years ago
|
||
Nightly 2016-10-16 a1768c915756429b74f73fac2e8dd4e7b4919730 good 2016-10-17 94b0fddf96b43942bdd851a3275042909ea37e09 bad Suspect changes for bug 1289148.
Blocks: 1289148
status-firefox51:
--- → unaffected
status-firefox52:
--- → affected
status-firefox53:
--- → affected
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → karlt
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8824923 [details] bug 1324256 consider scrollbar trough borders even for GTK versions < 3.20 https://reviewboard.mozilla.org/r/103262/#review104532 Looks good to me. I've tried with Ubuntu 16.04 and Greybird theme and it fix this problem.
Attachment #8824923 -
Flags: review?(jhorak) → review+
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8ed800907773 consider scrollbar trough borders even for GTK versions < 3.20 r=jhorak+328198
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8ed800907773
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Reporter | ||
Comment 10•7 years ago
|
||
Fixed in Nightly 20170114030206 :D Can someone please request approval-mozilla-aurora for this patch? I don't understand all the new lines in the approval request comment. Thanks!
Assignee | ||
Comment 11•7 years ago
|
||
Comment on attachment 8824923 [details] bug 1324256 consider scrollbar trough borders even for GTK versions < 3.20 Approval Request Comment [Feature/Bug causing the regression]: bug 1289148 [User impact if declined]: Funny looking scrollbars in some themes, including the default OS theme for Xubuntu 16.04 [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: Not particularly. [Why is the change risky/not risky?]: Non zero risk, because there is a large variety of different themes in use, it is impossible to test them all, and sometimes GTK doesn't behave as expected. [String changes made/needed]: None.
Attachment #8824923 -
Flags: approval-mozilla-aurora?
Comment 12•7 years ago
|
||
Comment on attachment 8824923 [details] bug 1324256 consider scrollbar trough borders even for GTK versions < 3.20 gtk widget fix for aurora52
Attachment #8824923 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 13•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/ceb9f76f1313
Comment 14•7 years ago
|
||
as a note, we see a small talos regression from this commit (on trunk- we are behind on sheriffing): == Change summary for alert #4940 (as of January 13 2017 09:23 UTC) == Regressions: 2% tp5o_scroll summary linux64 opt 6.62 -> 6.76 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=4940 I think this is partial noise and partial regression, given that the regression is small, I don't think spending a lot of time on this is worthwhile.
You need to log in
before you can comment on or make changes to this bug.
Description
•