Closed Bug 1324278 Opened 8 years ago Closed 7 years ago

Port FX changes for subdialogs.js to TB

Categories

(Thunderbird :: Preferences, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 53.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

This bug is to port changes to subdialog.js.

Ported bugs:

Bug 1130411 - deal with opening dialogs when the previous dialog is not unloaded yet
Bug 1264968 - Use replace uses of removed String.contains with the new .includes method
Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/
Bug 1191778 - remove references to mozapps content preferences.css stylesheet
Bug 1036595 - Convert the 'Clear recent history' dialog to be in-content

Not everything from this bugs is ported, only subdialog.js changes. Bug 1036595 for example has changes to a dialog we don't have but includes changes how the dialogs autofit to the content.
Attached patch subdialogs.patchSplinter Review
Proposed fix.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8819645 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8819645 [details] [diff] [review]
subdialogs.patch

Review of attachment 8819645 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable, thx! r=mkmelin
Attachment #8819645 - Flags: review?(mkmelin+mozilla) → review+
Thank you Magnus

https://hg.mozilla.org/comm-central/rev/72bc94bebbabfed990212cb8959c11fe5c974e05
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: