Website certificate superimposed over navigation back/forward

RESOLVED WORKSFORME

Status

()

Firefox for Android
General
--
major
RESOLVED WORKSFORME
8 months ago
6 months ago

People

(Reporter: David Ross, Assigned: maliu)

Tracking

(Blocks: 1 bug)

53 Branch
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(fennec53+, firefox50 ?, firefox51 ?, firefox52 ?, firefox53 affected)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Reporter)

Description

8 months ago
Created attachment 8819647 [details]
navigation.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20161217030205

Steps to reproduce:

Using Nightly on any website. After some activity the Tracking Protection/Website SSL Security Cert ends up superimposed over the top of the navigation buttons. Pretty consistent reproduction by simply going 'back' with my device native back key.


Actual results:

Clash of the icons


Expected results:

Everything should behave, just not today. Normal browser behaviour is what's expected.
From the URL bar it looks like this is happening on a tablet? I do not see this on my N9. What device and Android version are you using?

Comment 2

8 months ago
I can reproduce this issue using Asus ZenPad 8 (Android 6.0.1) and Asus Transformer Pad (Android 4.4.1).
On Nexus 9, I can't reproduce the issue.
Since I have no more tablet devices to test on, I can only assume that this is an Asus specific issue.
Flags: needinfo?(sw1ayfe)
tracking-fennec: --- → ?
Is this a regression? What versions are affected?
status-firefox50: --- → ?
status-firefox51: --- → ?
status-firefox52: --- → ?
status-firefox53: --- → ?
(Reporter)

Comment 4

8 months ago
This is a Samsung Galaxy Tab A running Android 6.0.1 (Marshmallow). Behaviour only experienced in Nightly Fennec 53 so far (and occurring irregularly), but have downloaded 52, 51, and 50. Will test further. Odd behaviour with these icon has it spaced over to the right when not layered on top of each other. Uploading image 'RIGHT'
Flags: needinfo?(sw1ayfe)
(Reporter)

Comment 5

8 months ago
Created attachment 8819884 [details]
RIGHT - Icon now shifts to the right on occassion.
Max: Did the RTL patches touch the tablet toolbar and could have caused this?
Flags: needinfo?(max)
status-firefox53: ? → affected
(Assignee)

Comment 7

8 months ago
(In reply to Sebastian Kaspari (:sebastian) from comment #6)
> Max: Did the RTL patches touch the tablet toolbar and could have caused this?
It's possible caused by RTL patches. Though similar symptom only happen on RTL context, I'll take it.
Assignee: nobody → max
Flags: needinfo?(max)
Comment hidden (mozreview-request)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → ASSIGNED
I just changed this to major.  this looks really ugly.  I don't think a release with this behavior can go forward.
Severity: normal → major
tracking-fennec: ? → 53+
(Assignee)

Updated

8 months ago
Attachment #8820585 - Flags: review?(s.kaspari)
Comment hidden (mozreview-request)

Comment 11

8 months ago
mozreview-review
Comment on attachment 8820585 [details]
Bug 1324280 - Revert MarginLayoutParamsCompat with setting margin left/right by current layout direction,

https://reviewboard.mozilla.org/r/100078/#review100978

::: mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbarTablet.java:13
(Diff revision 2)
> +import org.mozilla.gecko.R;
> +import org.mozilla.gecko.animation.PropertyAnimator;
> +import org.mozilla.gecko.animation.ViewHelper;
> +

Seems like those lines moved around. Let's try to not do this to avoid conflicts with other patches/uplifts. :)

::: mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbarTablet.java:101
(Diff revision 2)
> -                    MarginLayoutParamsCompat.setMarginStart(layoutParams, 0);
> +                    if (isLayoutRtl()) {
> +                        layoutParams.rightMargin = 0;
> +                    } else {
> +                        layoutParams.leftMargin = 0;
> +                    }

I thought that's what MarginLayoutParamsCompat does internally for older versions? But here we want to always update the left/right margin?
A comment in the bug / commit message / code would be helpful to help me and others understand. :)

::: mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbarTablet.java:109
(Diff revision 2)
> -                    MarginLayoutParamsCompat.setMarginStart(layoutParams, 0);
> +                    if (isLayoutRtl()) {
> +                        layoutParams.rightMargin = 0;
> +                    } else {
> +                        layoutParams.leftMargin = 0;
> +                    }

This pattern is repeated multiple times - do we want a helper method like the one in the compat class?
Attachment #8820585 - Flags: review?(s.kaspari) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 13

8 months ago
mozreview-review
Comment on attachment 8820585 [details]
Bug 1324280 - Revert MarginLayoutParamsCompat with setting margin left/right by current layout direction,

https://reviewboard.mozilla.org/r/100078/#review101026
(Assignee)

Updated

8 months ago
Keywords: checkin-needed

Comment 14

8 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d1a2b1de7f5
Revert MarginLayoutParamsCompat with setting margin left/right by current layout direction, r=sebastian
Keywords: checkin-needed

Comment 15

8 months ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/8d50229a6812
Revert MarginLayoutParamsCompat with setting margin left/right by current layout direction: lint style fixes. r=lint-fixes
(Assignee)

Updated

8 months ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
(Reporter)

Comment 16

8 months ago
Using Nightly (2017-01-03) this is not resolved. Forgive my ignorance, is there delay before pushed to Nightly? (See new attachment navbug.png)
Flags: needinfo?(max)
(Reporter)

Comment 17

8 months ago
Created attachment 8823335 [details]
navbug.png

Bug persistent in Nightly (2017-01-03)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Updated

8 months ago
Flags: needinfo?(max)
(Assignee)

Comment 18

8 months ago
Hi David,

Patch landed days ago and I have verify latest nightly(2017-01-03) pass on emulator from platform 17 to 24. Seems symptom remains on 23(marshmallow) only.

May I confirm what device/platform are you using please? Thank you.
Flags: needinfo?(sw1ayfe)
(Assignee)

Updated

8 months ago
Depends on: 1328515
(Reporter)

Comment 19

8 months ago
Samsung 'Galaxy Tab A' SM-T555 running Android Marshmallow 6.0.1 (Build number MMB29M.T555XXU1BPDA)
Flags: needinfo?(sw1ayfe) → needinfo?(max)
(Assignee)

Comment 20

8 months ago
Latest Nightly should include the solution patch. Please give it a try. Thank you.
Flags: needinfo?(max)
(Reporter)

Comment 21

8 months ago
Wahoo! Thanks a bunch everyone. Excellent job. That was such a frustrating bug for me.
Status: REOPENED → RESOLVED
Last Resolved: 8 months ago8 months ago
Resolution: --- → WORKSFORME
(Assignee)

Updated

6 months ago
Blocks: 702845
OS: Unspecified → Android
Hardware: Unspecified → All
(Assignee)

Updated

6 months ago
Duplicate of this bug: 1322142
You need to log in before you can comment on or make changes to this bug.