Port bug 658467 to TB [Fade out tab label on overflow instead of ellipsis]

RESOLVED FIXED in Thunderbird 53.0

Status

Thunderbird
Toolbars and Tabs
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 53.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

a year ago
FX no more shows an ellipsis on overflowed tabs text but a fade out.
With this we can gain up to two characters which can help to differentiate the tabs with similar title.
(Assignee)

Comment 1

a year ago
Created attachment 8819649 [details] [diff] [review]
fadeOutTabLabel.patch

Port of FX patch.

I also removed the not needed stack with tabs-bottom, tabs-bottom-spacer and tabs-left.

Magnus, I ran in a problem where the tabcontainer got the overflow="true" flag with only one tab with a overflowed text (the text wasn't longer than the tabcontainer). So I changed the logic to show the alltabs-button. Is this okay like this or do you know where the overflow logic is and why this can happen? It must be a difference because this doesn't happen in FX.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8819649 - Flags: review?(mkmelin+mozilla)
(Assignee)

Comment 2

a year ago
Created attachment 8822130 [details] [diff] [review]
fadeOutTabLabel.patch

Updated to tip after landing of bug 1325924.
Attachment #8819649 - Attachment is obsolete: true
Attachment #8819649 - Flags: review?(mkmelin+mozilla)
Attachment #8822130 - Flags: review?(mkmelin+mozilla)

Comment 3

a year ago
Created attachment 8822236 [details]
fadetab.png

Seems to interact badly with the background. Texts are barely readable in the non-selected tabs.

Comment 4

a year ago
Comment on attachment 8822130 [details] [diff] [review]
fadeOutTabLabel.patch

Review of attachment 8822130 [details] [diff] [review]:
-----------------------------------------------------------------

Needs some work on the background text color. The screenshot was on Ubuntu.
Attachment #8822130 - Flags: review?(mkmelin+mozilla) → review-
(Assignee)

Comment 5

a year ago
Created attachment 8822255 [details] [diff] [review]
fadeOutTabLabel.patch

I forgot we have now the tab-label-container.
Attachment #8822130 - Attachment is obsolete: true
Attachment #8822255 - Flags: review?(mkmelin+mozilla)

Comment 6

a year ago
Comment on attachment 8822255 [details] [diff] [review]
fadeOutTabLabel.patch

Review of attachment 8822255 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #8822255 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 7

a year ago
https://hg.mozilla.org/comm-central/rev/2ddba872ddfe19343e5dc1c61bd1e7f4226fe630
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
You need to log in before you can comment on or make changes to this bug.