1324281 - Port bug 658467 to TB [Fade out tab label on overflow instead of ellipsis]

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Richard Marti (:Paenglab)]

FX no more shows an ellipsis on overflowed tabs text but a fade out.
With this we can gain up to two characters which can help to differentiate the tabs with similar title.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: fadeOutTabLabel.patch

Port of FX patch.

I also removed the not needed stack with tabs-bottom, tabs-bottom-spacer and tabs-left.

Magnus, I ran in a problem where the tabcontainer got the overflow="true" flag with only one tab with a overflowed text (the text wasn't longer than the tabcontainer). So I changed the logic to show the alltabs-button. Is this okay like this or do you know where the overflow logic is and why this can happen? It must be a difference because this doesn't happen in FX.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: fadeOutTabLabel.patch

Updated to tip after landing of bug 1325924.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: fadetab.png

Seems to interact badly with the background. Texts are barely readable in the non-selected tabs.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 8822130 [details] [diff] [review]
fadeOutTabLabel.patch

Review of attachment 8822130 [details] [diff] [review]:
-----------------------------------------------------------------

Needs some work on the background text color. The screenshot was on Ubuntu.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: fadeOutTabLabel.patch

I forgot we have now the tab-label-container.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 8822255 [details] [diff] [review]
fadeOutTabLabel.patch

Review of attachment 8822255 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 7

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/2ddba872ddfe19343e5dc1c61bd1e7f4226fe630