need accesskey for "Close" button in find and replace when composing message

RESOLVED FIXED in Thunderbird 53.0

Status

defect
--
minor
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wsmwk, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 53.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This keeps biting me.

open compose
do ctrl+F
do alt+L

close has no accesskey. "L" is available :)
Posted patch 20894.patchSplinter Review
"L" isn't a good letter for accesskeys because the lowercase l is too narrow to have a remarkable underscore line.

I choose "C" and changed the "Match exact case" to "M". If the "c" would be on _c_ase, then I would leave it, but on exa_c_t it's not very obvious.

I also haven't changed the caseSensitiveCheckbox.accesskey entity to caseSensitiveCheckbox1.accesskey because it's not likely other locales need also to change this accesskey.

Aceman, sorry for the lot of white space changes in EdReplace.xul but after this bug it's clean. ;)
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8819671 - Flags: review?(acelists)
Why does the dialog even have a Close button? I couldn't find any other one with such a button.
Isn't ESC enough for a key?
The Check Spelling dialog has one too. And it has also "C" as accesskey.
Comment on attachment 8819671 [details] [diff] [review]
20894.patch

Review of attachment 8819671 [details] [diff] [review]:
-----------------------------------------------------------------

Ok then.
Attachment #8819671 - Flags: review?(acelists) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/e941c4d85867835a21f682492cc1957553a1de7b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.