1324292 - need accesskey for "Close" button in find and replace when composing message

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Wayne Mery (:wsmwk)]

This keeps biting me.

open compose
do ctrl+F
do alt+L

close has no accesskey. "L" is available :)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 20894.patch

"L" isn't a good letter for accesskeys because the lowercase l is too narrow to have a remarkable underscore line.

I choose "C" and changed the "Match exact case" to "M". If the "c" would be on _c_ase, then I would leave it, but on exa_c_t it's not very obvious.

I also haven't changed the caseSensitiveCheckbox.accesskey entity to caseSensitiveCheckbox1.accesskey because it's not likely other locales need also to change this accesskey.

Aceman, sorry for the lot of white space changes in EdReplace.xul but after this bug it's clean. ;)

Comment 2

[:aceman]

Why does the dialog even have a Close button? I couldn't find any other one with such a button.
Isn't ESC enough for a key?

Comment 3

[Richard Marti (:Paenglab)]

The Check Spelling dialog has one too. And it has also "C" as accesskey.

Comment 4

[:aceman]

Comment on attachment 8819671 [details] [diff] [review]
20894.patch

Review of attachment 8819671 [details] [diff] [review]:
-----------------------------------------------------------------

Ok then.

Comment 5

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/e941c4d85867835a21f682492cc1957553a1de7b