1324296 - force-cargo-library-build is noisy

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mats Palmgren (inactive)]

STR
1. ./mach build

ACTUAL RESULTS
 0:01.36 force-cargo-library-build
 0:01.54        Fresh mp4parse-gtest v0.1.0 (file:///md1/src/inbound/dom/media/gtest)
 0:01.54        Fresh matches v0.1.3
 0:01.54        Fresh unicode-normalization v0.1.2
 0:01.54        Fresh nsstring v0.1.0 (file:///md1/src/inbound/xpcom/rust/nsstring)
 0:01.54        Fresh libc v0.2.16
 0:01.54        Fresh byteorder v0.5.3
 0:01.55        Fresh unicode-bidi v0.2.3
 0:01.55        Fresh idna v0.1.0
 0:01.55        Fresh nsstring-gtest v0.1.0 (file:///md1/src/inbound/xpcom/rust/nsstring/gtest)
 0:01.55        Fresh mp4parse v0.6.0 (file:///md1/src/inbound/media/libstagefright/binding/mp4parse)
 0:01.55        Fresh mp4parse_capi v0.6.0 (file:///md1/src/inbound/media/libstagefright/binding/mp4parse_capi)
 0:01.56        Fresh url v1.2.1
 0:01.56        Fresh rust_url_capi v0.0.1 (file:///md1/src/inbound/netwerk/base/rust-url-capi)
 0:01.56        Fresh gkrust-shared v0.1.0 (file:///md1/src/inbound/toolkit/library/rust/shared)
 0:01.57        Fresh gkrust-gtest v0.1.0 (file:///md1/src/inbound/toolkit/library/gtest/rust)
 0:01.57     Finished debug [optimized + debuginfo] target(s) in 0.2 secs
 0:01.81 force-cargo-library-build
 0:01.93        Fresh unicode-normalization v0.1.2
 0:01.93        Fresh nsstring v0.1.0 (file:///md1/src/inbound/xpcom/rust/nsstring)
 0:01.93        Fresh byteorder v0.5.3
 0:01.93        Fresh libc v0.2.16
 0:01.93        Fresh matches v0.1.3
 0:01.93        Fresh mp4parse v0.6.0 (file:///md1/src/inbound/media/libstagefright/binding/mp4parse)
 0:01.93        Fresh unicode-bidi v0.2.3
 0:01.94        Fresh mp4parse_capi v0.6.0 (file:///md1/src/inbound/media/libstagefright/binding/mp4parse_capi)
 0:01.94        Fresh idna v0.1.0
 0:01.94        Fresh url v1.2.1
 0:01.94        Fresh rust_url_capi v0.0.1 (file:///md1/src/inbound/netwerk/base/rust-url-capi)
 0:01.94        Fresh gkrust-shared v0.1.0 (file:///md1/src/inbound/toolkit/library/rust/shared)
 0:01.94        Fresh gkrust v0.1.0 (file:///md1/src/inbound/toolkit/library/rust)
 0:01.94     Finished debug [optimized + debuginfo] target(s) in 0.0 secs

EXPECTED RESULTS

Comment 2

[(not currently active) Ted Mielczarek]

This is because we unconditionally pass --verbose to `cargo build` right now:
https://dxr.mozilla.org/mozilla-central/rev/b1c31c4a0a678194931779e0f13fba7b508eb109/config/rules.mk#922

Without that a no-op `cargo build` only outputs one line:
    Finished debug [unoptimized + debuginfo] target(s) in 0.0 secs

we use `BUILD_VERBOSE_LOG` to enable or disable verbose output elsewhere, we should probably just wrap that --verbose line with that same conditional:
https://dxr.mozilla.org/mozilla-central/rev/b1c31c4a0a678194931779e0f13fba7b508eb109/config/rules.mk#36

(I believe that's what makes `mach build -v` work.)

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: only enable verbose cargo output if BUILD_VERBOSE_LOG

This mirrors what we do elsewhere for C/C++/etc.

...but I can't figure out where we define BUILD_VERBOSE_LOG!  A grep in
srcdir/objdir only results in ifdef checks for it, and a DXR search confirms
that result.  Is this leftover from some previous bits of the build system?

Comment 4

[(not currently active) Ted Mielczarek]

From https://hg.mozilla.org/mozilla-central/rev/a4cc25ae5b7d :

"If people like verbosity, they can export the undocumented
BUILD_VERBOSE_LOG environment variable can be set to restore the old
behavior."

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df4ebc3b373c
only enable verbose cargo output if BUILD_VERBOSE_LOG; r=ted.mielczarek

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df4ebc3b373c