1324328 - Remove MozChecker and some unused code

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Comment 1

[(no longer active)]

Attachment: Remove MozChecker and some unused code

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8819711 [details] [diff] [review]
Remove MozChecker and some unused code

Review of attachment 8819711 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

::: build/clang-plugin/Utils.h
@@ +348,5 @@
>    CXXRecordDecl *Clazz = T->getAsCXXRecordDecl();
>    return Clazz ? getBaseRefCntMember(Clazz) : 0;
>  }
>  
> +inline bool hasCustomAnnotation(const Decl *D, const char *Spelling) {

I feel like Spelling should be a StringRef here, but it probably doesn't matter.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20134b5c4194
Remove MozChecker and some unused code; r=mystor

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79cdd0e0ee9b
follow-up: Make hasCustomAnnotation's second argument a StringRef

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/20134b5c4194
https://hg.mozilla.org/mozilla-central/rev/79cdd0e0ee9b