Closed
Bug 1324371
Opened 7 years ago
Closed 7 years ago
Finish NextFrameSeekingState as soon as possible
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(6 files)
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
https://hg.mozilla.org/mozilla-central/file/77c3f2e77448/dom/media/MediaDecoderStateMachine.cpp#l1622 There is no more promise to be resolved asynchronously. We can finish seek without waiting for pending audio/video requests.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jwwang
Priority: -- → P3
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8820549 [details] Bug 1324371. Part 1 - remove IsAudioSeekComplete(). https://reviewboard.mozilla.org/r/100028/#review100588
Attachment #8820549 -
Flags: review?(kaku) → review+
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8820550 [details] Bug 1324371. Part 2 - remove IsVideoSeekComplete() and finish seek without waiting for pending video requests. https://reviewboard.mozilla.org/r/100030/#review100590
Attachment #8820550 -
Flags: review?(kaku) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8820551 [details] Bug 1324371. Part 3 - inline IsVideoRequestPending() which has only one caller. https://reviewboard.mozilla.org/r/100032/#review100592
Attachment #8820551 -
Flags: review?(kaku) → review+
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8820552 [details] Bug 1324371. Part 4 - assert NeedMoreVideo() in some functions. https://reviewboard.mozilla.org/r/100034/#review100594
Attachment #8820552 -
Flags: review?(kaku) → review+
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8820553 [details] Bug 1324371. Part 5 - add FinishSeek() and remove MaybeFinishSeek(). https://reviewboard.mozilla.org/r/100036/#review100596
Attachment #8820553 -
Flags: review?(kaku) → review+
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8820554 [details] Bug 1324371. Part 6 - assert |VideoQueue().AtEndOfStream()|. https://reviewboard.mozilla.org/r/100038/#review100598
Attachment #8820554 -
Flags: review?(kaku) → review+
Assignee | ||
Comment 13•7 years ago
|
||
Thanks!
Comment 14•7 years ago
|
||
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56f60b5fae24 Part 1 - remove IsAudioSeekComplete(). r=kaku https://hg.mozilla.org/integration/autoland/rev/e097854a5983 Part 2 - remove IsVideoSeekComplete() and finish seek without waiting for pending video requests. r=kaku https://hg.mozilla.org/integration/autoland/rev/679fbd200d42 Part 3 - inline IsVideoRequestPending() which has only one caller. r=kaku https://hg.mozilla.org/integration/autoland/rev/bd2b624eac7f Part 4 - assert NeedMoreVideo() in some functions. r=kaku https://hg.mozilla.org/integration/autoland/rev/be2e779e0467 Part 5 - add FinishSeek() and remove MaybeFinishSeek(). r=kaku https://hg.mozilla.org/integration/autoland/rev/3ca687d4f281 Part 6 - assert |VideoQueue().AtEndOfStream()|. r=kaku
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/56f60b5fae24 https://hg.mozilla.org/mozilla-central/rev/e097854a5983 https://hg.mozilla.org/mozilla-central/rev/679fbd200d42 https://hg.mozilla.org/mozilla-central/rev/bd2b624eac7f https://hg.mozilla.org/mozilla-central/rev/be2e779e0467 https://hg.mozilla.org/mozilla-central/rev/3ca687d4f281
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•