Finish NextFrameSeekingState as soon as possible

RESOLVED FIXED in Firefox 53

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(6 attachments)

(Assignee)

Description

a year ago
https://hg.mozilla.org/mozilla-central/file/77c3f2e77448/dom/media/MediaDecoderStateMachine.cpp#l1622

There is no more promise to be resolved asynchronously. We can finish seek without  waiting for pending audio/video requests.
(Assignee)

Updated

a year ago
Assignee: nobody → jwwang
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 7

a year ago
mozreview-review
Comment on attachment 8820549 [details]
Bug 1324371. Part 1 - remove IsAudioSeekComplete().

https://reviewboard.mozilla.org/r/100028/#review100588
Attachment #8820549 - Flags: review?(kaku) → review+

Comment 8

a year ago
mozreview-review
Comment on attachment 8820550 [details]
Bug 1324371. Part 2 - remove IsVideoSeekComplete() and finish seek without waiting for pending video requests.

https://reviewboard.mozilla.org/r/100030/#review100590
Attachment #8820550 - Flags: review?(kaku) → review+

Comment 9

a year ago
mozreview-review
Comment on attachment 8820551 [details]
Bug 1324371. Part 3 - inline IsVideoRequestPending() which has only one caller.

https://reviewboard.mozilla.org/r/100032/#review100592
Attachment #8820551 - Flags: review?(kaku) → review+

Comment 10

a year ago
mozreview-review
Comment on attachment 8820552 [details]
Bug 1324371. Part 4 - assert NeedMoreVideo() in some functions.

https://reviewboard.mozilla.org/r/100034/#review100594
Attachment #8820552 - Flags: review?(kaku) → review+

Comment 11

a year ago
mozreview-review
Comment on attachment 8820553 [details]
Bug 1324371. Part 5 - add FinishSeek() and remove MaybeFinishSeek().

https://reviewboard.mozilla.org/r/100036/#review100596
Attachment #8820553 - Flags: review?(kaku) → review+

Comment 12

a year ago
mozreview-review
Comment on attachment 8820554 [details]
Bug 1324371. Part 6 - assert |VideoQueue().AtEndOfStream()|.

https://reviewboard.mozilla.org/r/100038/#review100598
Attachment #8820554 - Flags: review?(kaku) → review+
(Assignee)

Comment 13

a year ago
Thanks!

Comment 14

a year ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/56f60b5fae24
Part 1 - remove IsAudioSeekComplete(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/e097854a5983
Part 2 - remove IsVideoSeekComplete() and finish seek without waiting for pending video requests. r=kaku
https://hg.mozilla.org/integration/autoland/rev/679fbd200d42
Part 3 - inline IsVideoRequestPending() which has only one caller. r=kaku
https://hg.mozilla.org/integration/autoland/rev/bd2b624eac7f
Part 4 - assert NeedMoreVideo() in some functions. r=kaku
https://hg.mozilla.org/integration/autoland/rev/be2e779e0467
Part 5 - add FinishSeek() and remove MaybeFinishSeek(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/3ca687d4f281
Part 6 - assert |VideoQueue().AtEndOfStream()|. r=kaku
You need to log in before you can comment on or make changes to this bug.