Closed Bug 1324376 Opened 3 years ago Closed 3 years ago

Request GLES3 in GLContextProviderEGL::CreateForWindow

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54

People

(Reporter: sotaro, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

GLES3 is necessary for webrender.
Assignee: nobody → sotaro.ikeda.g
IsAccelAngleSupported() calls gfxUtils::ThreadSafeGetFeatureStatus() and it caused nullptr deref and abort on Compositor thread :-(
   https://dxr.mozilla.org/mozilla-central/source/gfx/gl/GLLibraryEGL.cpp#153
(In reply to Sotaro Ikeda [:sotaro] from comment #2)
> IsAccelAngleSupported() calls gfxUtils::ThreadSafeGetFeatureStatus() and it
> caused nullptr deref and abort on Compositor thread :-(
>    https://dxr.mozilla.org/mozilla-central/source/gfx/gl/GLLibraryEGL.cpp#153

We do not need to check gfxUtils::ThreadSafeGetFeatureStatus() here for a webrender case. It is for webgl.
We we want to check black list of webrender ANGLE, we could do it in a different place.
Attachment #8819831 - Flags: review?(nical.bugzilla)
Attachment #8819831 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/7a4e657e1d42
Request GLES3 in GLContextProviderEGL::CreateForWindow r=niacl
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.