Closed
Bug 1324376
Opened 7 years ago
Closed 7 years ago
Request GLES3 in GLContextProviderEGL::CreateForWindow
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.52 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
GLES3 is necessary for webrender.
|
Assignee | |
Updated•7 years ago
|
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
IsAccelAngleSupported() calls gfxUtils::ThreadSafeGetFeatureStatus() and it caused nullptr deref and abort on Compositor thread :-( https://dxr.mozilla.org/mozilla-central/source/gfx/gl/GLLibraryEGL.cpp#153
|
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #2) > IsAccelAngleSupported() calls gfxUtils::ThreadSafeGetFeatureStatus() and it > caused nullptr deref and abort on Compositor thread :-( > https://dxr.mozilla.org/mozilla-central/source/gfx/gl/GLLibraryEGL.cpp#153 We do not need to check gfxUtils::ThreadSafeGetFeatureStatus() here for a webrender case. It is for webgl.
|
|
Assignee | |
Comment 4•7 years ago
|
||
We we want to check black list of webrender ANGLE, we could do it in a different place.
|
|
Assignee | |
Comment 5•7 years ago
|
||
Attachment #8819819 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8819831 -
Flags: review?(nical.bugzilla)
|
||
Updated•7 years ago
|
Attachment #8819831 -
Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/7a4e657e1d42 Request GLES3 in GLContextProviderEGL::CreateForWindow r=niacl
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•