reference pre-built docker images by hash (image_builder in particular)

RESOLVED FIXED in mozilla53

Status

Taskcluster
Task Configuration
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: jonasfj, Assigned: jonasfj)

Tracking

unspecified
mozilla53

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
This probably only relevant to image_builder, but we need to update all the
machinery...
Comment hidden (mozreview-request)
Assignee: nobody → jopsen

Comment 2

10 months ago
mozreview-review
Comment on attachment 8819873 [details]
Bug 1324414 - Reference prebuilt docker images by HASH.

https://reviewboard.mozilla.org/r/99516/#review99984

::: testing/docker/README.md:85
(Diff revision 1)
>  ***Deprecation Warning: Use of prebuilt images should only be used for base images (those that other images
>  will inherit from), or private images that must be stored in a private docker registry account.  Existing
>  public images will be converted to images that are built on push and any newly added image should
>  follow this pattern.***
>  
>  These are images that are intended to be pushed to a docker registry and used by specifying the

This isn't really accurate anymore either, is it?

::: testing/docker/README.md:93
(Diff revision 1)
>  
>  Example:
>    image: {#docker_image}builder{/docker_image}
>  
> -Each image has a version, given by its `VERSION` file.  This should be bumped when any changes are made that will be deployed into taskcluster.
> -Then, older tasks which were designed to run on an older version of the image can still be executed in taskcluster, while new tasks can use the new version.
> +Each image has a hash and a version, given by its `HASH` and `VERSION` files.
> +When rebuilding a prebuilt image the `VERSION` should be bumped. Once a new

Please define "prebuilt" here (I think you mean, an image that can't be built automatically)
Attachment #8819873 - Flags: review?(dustin) → review+
(Assignee)

Comment 3

10 months ago
mozreview-review-reply
Comment on attachment 8819873 [details]
Bug 1324414 - Reference prebuilt docker images by HASH.

https://reviewboard.mozilla.org/r/99516/#review99984

> This isn't really accurate anymore either, is it?

How is it not, the prebuilt images are intended to be pushed a docker registry and used by specifying the folder name.
Oh, I didn't see the lines above that (which also define prebuilt images).  Please ignore all of my comments :)
(Assignee)

Comment 5

10 months ago
Yay, let's land... Arguably our docs could be better.
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 6

10 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65eba2a42004
Reference prebuilt docker images by HASH. r=dustin
Keywords: checkin-needed

Comment 7

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/65eba2a42004
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(Assignee)

Updated

10 months ago
See Also: → bug 1325132
You need to log in before you can comment on or make changes to this bug.