Switch from HttpBaseChannel::QueryHttpChannelImpl to QueryObject(nsHttpChannel)

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mayhemer, Assigned: mayhemer)

Tracking

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox53 affected, firefox54 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment)

Assignee: nobody → honzab.moz
Whiteboard: [necko-active]
(Assignee)

Updated

2 years ago
Duplicate of this bug: 1329910
(Assignee)

Comment 2

2 years ago
I found out that we already have it implemented, landed as part of bug 1024730.

Converting the bug appropriately.
Status: NEW → ASSIGNED
Summary: Allow QueryObject to nsHttpChannel → Switch from HttpBaseChannel::QueryHttpChannelImpl to QueryObject(nsHttpChannel)
(Assignee)

Comment 3

2 years ago
Created attachment 8838585 [details] [diff] [review]
v1

- removes the redundant QueryHttpChannelImpl method
- few of the static_cast<nsHttpChannel*> switched to do_QueryObject(), regardless whether are considered safe or not

https://treeherder.mozilla.org/#/jobs?repo=try&revision=696ca75ecb12ed30f0672d9dd80d595ef09970bb
Attachment #8838585 - Flags: review?(mcmanus)
Comment on attachment 8838585 [details] [diff] [review]
v1

Review of attachment 8838585 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the cleanup
Attachment #8838585 - Flags: review?(mcmanus) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a622d810dcb5
Use QueryObject for nsHttpChannel. r=mcmanus
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a622d810dcb5
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.