Closed Bug 1324419 Opened 4 years ago Closed 4 years ago

Switch from HttpBaseChannel::QueryHttpChannelImpl to QueryObject(nsHttpChannel)

Categories

(Core :: Networking: HTTP, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox53 --- affected
firefox54 --- fixed

People

(Reporter: mayhemer, Assigned: mayhemer)

References

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

Assignee: nobody → honzab.moz
Whiteboard: [necko-active]
Duplicate of this bug: 1329910
I found out that we already have it implemented, landed as part of bug 1024730.

Converting the bug appropriately.
Status: NEW → ASSIGNED
Summary: Allow QueryObject to nsHttpChannel → Switch from HttpBaseChannel::QueryHttpChannelImpl to QueryObject(nsHttpChannel)
Attached patch v1Splinter Review
- removes the redundant QueryHttpChannelImpl method
- few of the static_cast<nsHttpChannel*> switched to do_QueryObject(), regardless whether are considered safe or not

https://treeherder.mozilla.org/#/jobs?repo=try&revision=696ca75ecb12ed30f0672d9dd80d595ef09970bb
Attachment #8838585 - Flags: review?(mcmanus)
Comment on attachment 8838585 [details] [diff] [review]
v1

Review of attachment 8838585 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the cleanup
Attachment #8838585 - Flags: review?(mcmanus) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a622d810dcb5
Use QueryObject for nsHttpChannel. r=mcmanus
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a622d810dcb5
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.