Closed Bug 1324472 Opened 3 years ago Closed 3 years ago

do a webrender update to 9488286d1bd5307e1d907d206114d9c42425040d or newer

Categories

(Core :: Graphics: WebRender, defect, P3)

53 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox53 --- affected

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

m-c got an updated third_party/rust/url library. This makes doing a merge from m-c to graphics complicated, because it results in conflicts in the gkrust Cargo.lock files which is not safe to resolve manually. I filed bug 1324462 for a sane way to handle this.

In the meantime, I'd like to do a |mach vendor rust| on the graphics branch *before* doing this m-c merge, to make the merge simpler. However doing that vendor rust causes compile bustage because of a change to the euclid library [1]. In order to fix that compile bustage we need to do a full webrender update to 9488286d1bd5307e1d907d206114d9c42425040d or newer.

[1] https://github.com/servo/euclid/pull/170#issuecomment-268012820
I found a way to do the merge without the webrender update. But still, it's worth pulling in a new webrender so we don't get too far behind. I did it locally and have a try push going to see if it affects the reftests in any way:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0104e206a7c0c82aa6318690ab363936c8409bd0
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/ea33a7be3419
Update webrender{,_traits} to 9839014c9a7269494fb40c1300f9e686738d42a3. r=gfx?
https://hg.mozilla.org/projects/graphics/rev/fe8b83694f3f
Revendor rust dependencies. r=gfx?
https://hg.mozilla.org/projects/graphics/rev/39d87131faa0
Add typed units and missing options in webrender_bindings to go with webrender update. r=gfx?
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/138d3e518727
Update webrender_bindings to use LayoutRect instead of LayerRect. r=nical?
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.