1324473 - xargs.exe crashes at toolkit/library/libxul.mk if you set PATH env to the suggested path of |./mach bootstrap|

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

On the last weekend, mozilla-central starts to require Rust in default buildconfig. If you don't install Rust, |./mach build| recommends to use |./mach bootstrap| to install Rust compiler. Then, |./mach bootstrap| will suggest that the developer should add |export PATH=c:/Users/<user name>\.cargo\bin:$PATH| to .profile.

However, with this config, xargs.exe will be crashed when linker works for xul.dll. The point is here:
https://dxr.mozilla.org/mozilla-central/rev/2824deb82146bba070995a762cfc98ddb2d1decb/toolkit/library/libxul.mk#61

At this time, you see only "NSModules are not ordered appropriately" in the terminal. This doesn't help you to resolve this crash.

The wrong point is, the recommended path is wrong for mozilla-build. For mozilla-build, it should be |export PATH=/c/Users/toybox/.cargo/bin:$PATH|. All '\'s should be replaced with '/' and |c:\| should be |/c/|.

I've still not fully understand the reason why this causes xargs.exe crashing. However, I correct the path, I don't see the crash anymore.

I wasted 2 days with this bug, please fix this bug as soon as possible for preventing to make other developers not confused by this bug.

Comment 1

[Gregory Szorc [:gps]]

Looks like we need a wording change in `mach bootstrap`.

(This is a really wonky bug. I can't believe xargs.exe is flat out crashing.)

Comment 2

[Ralph Giles (:rillian)]

Yeah, Sorry. I think I was normalizing the path message in my head. We'll have to unix-ize it before printing. Even better, on my system it comes out

  PATH=c:/Users/mozilla\.cargo\bin:$PATH

So perhaps we can just s#$([a-zA-Z]):/#/\1/ and s#\\#/#.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Hi Ralph, any chance to fix this in-tree soon? Especially because of the opaque error message. Thank you.

Comment 4

[Ralph Giles (:rillian)]

I'm on PTO starting tomorrow, so I can't promise. I'll try to get a patch ready today at least.

Comment 5

[Ralph Giles (:rillian)]

Attachment: Bug 1324473 - mozboot: Normalize windows path advice.

On windows, python generally returns windows-style paths,
with drive letters and backslash for a separator. However,
when we offer advice for updating the PATH variable, we're
talking about the msys environment which uses unix-style
paths. Convert to avoid confusion.

This is intended to turn c:\Users\mozilla\ into /c/Users/mozilla/.

Review commit: https://reviewboard.mozilla.org/r/100662/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100662/

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8821356 [details]
Bug 1324473 - mozboot: Normalize windows path advice.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100662/diff/1-2/

Comment 7

[Ralph Giles (:rillian)]

This isn't especially pretty, but resolves the immediate issue for me. I'm away until January; will follow up then. In the meantime, anyone should feel free to take this on can get a fix landed.

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8821356 [details]
Bug 1324473 - mozboot: Normalize windows path advice.

https://reviewboard.mozilla.org/r/100662/#review101672

I could nitpick a thing or two with the path transformation. But since this code is limited to the bootstrapper and is only used as part of printing a path, it should be fine. If it isn't, I'm sure people will file follow-up bugs.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/737708b15086
mozboot: Normalize windows path advice. r=gps

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/737708b15086

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

If someone still has issues with xargs:
After the fix landed, I (still?) had xargs crashes when I tried to run |mozmake unpack| during the l10n binary repack https://developer.mozilla.org/en-US/docs/Mozilla/Creating_a_language_pack#L10n_binary_repack
Removing the cargo line from the .profile file fixed the issue.

Comment 12

[Masatoshi Kimura [:emk]]

This fix only changes the instruction message. It does not fix wrong $PATH settings automatically if it is already set.