1324489 - Bugzilla::Config doesn't validate existing parameters

Status: NEW

(Bugzilla :: Bugzilla-General, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

Somehow my attachment_storage got set to '', which shouldn't be a valid value.
However the code checks if the value is 's3', and if so requires
the s3 feature to be enabled or returns an error.
If the value is not s3, it returns '' rather than $check_multi.

This is similar to code swallowing exceptions, as we use non-empty strings to signal exceptions here.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Checksetup should probably validate() most of the checker functions to ensure that data/params.json values are still valid.

Possibly treat invalid values as unset 
(and maybe writing the invalid values out to a file?)