Closed Bug 1324555 Opened 3 years ago Closed 3 years ago
Don't store our own copy of Emoji
One Mozilla .ttf in mail/fonts
We have now our own copy of EmojiOneMozilla.ttf, a 1.2 MB file, in mail/fonts. Instead we should use the one from mozilla/browser. The pro for this is also we don't need to look for updates, when one would be available.
Packaging like SM
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8820037 - Flags: review?(jorgk)
I'm comparing this to https://hg.mozilla.org/comm-central/rev/f03dbcdc6fe9 and they have something in suite/installer/Makefile.in https://hg.mozilla.org/comm-central/rev/f03dbcdc6fe9#l3.17 Equivalent would be mail/installer/Makefile.in Is this needed?
(In reply to Jorg K (GMT+1) from comment #2) > I'm comparing this to > https://hg.mozilla.org/comm-central/rev/f03dbcdc6fe9 > and they have something in suite/installer/Makefile.in > https://hg.mozilla.org/comm-central/rev/f03dbcdc6fe9#l3.17 > Equivalent would be mail/installer/Makefile.in > Is this needed? Not really. My earlier patch also works but IanN wanted a more "integrated" solution. Us seamonkey reviewers are sometimes too picky.
Comment on attachment 8820037 [details] [diff] [review] bug1324555.patch OK, thanks for the quick reply. I'll land this now.
Attachment #8820037 - Flags: review?(jorgk) → review+
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
Um sorry for the misunderstanding. If you do this in package-manifest.in: if defined(XP_WIN) || defined(XP_LINUX) @RESPATH@/fonts/* #endif Then you don't need this in the installer/Makefile.in: ifdef MOZ_BUNDLED_FONTS DEFINES += -DMOZ_BUNDLED_FONTS=1 endif ...................................................... If you want to do this in package-manifest.in: #ifdef MOZ_BUNDLED_FONTS @RESPATH@/fonts/* #endif Then you need in Makefile.in: ifdef MOZ_BUNDLED_FONTS DEFINES += -DMOZ_BUNDLED_FONTS=1 endif
Landed follow-up: https://hg.mozilla.org/comm-central/rev/b6764a038123881a4422370fb6e8ead6bf7f0e73 Thanks for the review!
You need to log in before you can comment on or make changes to this bug.