1324556 - new message keyboard shortcut not working

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[long]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46
Build ID: 20161005021738

Steps to reproduce:

Create new profile.
Start new profile in safe mode.
Press Shift+Command+M



Actual results:

Nothing other than sometimes the Tools menu flashes, other times the File menu.


Expected results:

A new message composition window opens.

Comment 1

[long]

I'm 98% sure this was working fine in SM 2.40

Comment 2

[Frank-Rainer Grahl (:frg)]

Works under Windows with Ctrl-M. Stefan could you check it on OSX.

Comment 3

[Stefan [:stefanh]]

Yeah, looks like there's a conflict with the "Responsive Design View" key here... On trunk, hitting Cmd+Shift+M when the browser window is in front, I get this:
*************************
A coding exception was thrown and uncaught in a Task.

Full message: TypeError: aWindow.gBrowser.getBrowserContainer is not a function
Full stack: ResponsiveUI@resource://devtools/client/responsivedesign/responsivedesign.jsm:172:20
Manager.openIfNeeded<@resource://devtools/client/responsivedesign/responsivedesign.jsm:79:12
_run@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:311:39
TaskImpl@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:273:3
asyncFunction@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:247:14
toggle@resource://devtools/client/responsivedesign/responsivedesign.jsm:65:7
toggle@chrome://navigator/content/webDeveloperOverlay.js:18:5
oncommand@chrome://navigator/content/navigator.xul:1:1

*************************

Now, looking at https://dxr.mozilla.org/comm-central/rev/9dff59feff428451f3cbf5d3fe0b7934153558d1/suite/browser/webDeveloperOverlay.xul#102 and https://dxr.mozilla.org/comm-central/rev/9dff59feff428451f3cbf5d3fe0b7934153558d1/suite/locales/en-US/chrome/browser/webDeveloper.dtd#22 the conflict is obvious. The funny thing is that the shortcut shown in the menuitem is Cmd+Alt+M which I guess comes from https://dxr.mozilla.org/mozilla-central/rev/1156db49e976173fc3cf90d2126456fd1e2bae4b/devtools/client/menus.js#140

Comment 4

[Stefan [:stefanh]]

Btw, the "new Message" shortcut works when the mail window is in front.

Comment 5

[Stefan [:stefanh]]

A quick fix is to just remove the modifiers at https://dxr.mozilla.org/comm-central/rev/9dff59feff428451f3cbf5d3fe0b7934153558d1/suite/browser/webDeveloperOverlay.xul#102 (the menuitem "Responsive Design View" doesn't work at all for me, so it's no loss...).

Comment 6

[Stefan [:stefanh]]

Philip, see comment #3 and comment #5 - do you have any other suggestions?

Comment 7

[Philip Chee]

(In reply to Stefan [:stefanh] from comment #5)
> A quick fix is to just remove the modifiers at
> https://dxr.mozilla.org/comm-central/rev/
> 9dff59feff428451f3cbf5d3fe0b7934153558d1/suite/browser/webDeveloperOverlay.
> xul#102 (the menuitem "Responsive Design View" doesn't work at all for me,
> so it's no loss...).
Well yeah lets kill the "Responsive Design View" until we have a working RDV.

Comment 8

[long]

Keyboard shortcut still not working in 2.48

Comment 9

[Frank-Rainer Grahl (:frg)]

Attachment: 1373374-quotationmarks.patch

Sorry I lost track of this. I will see that it gets into 2.49.1

Comment 10

[Frank-Rainer Grahl (:frg)]

Attachment: 1324556-resonsiveUIKey.patch

oops wrong patch

Comment 11

[Stefan [:stefanh]]

Comment on attachment 8895905 [details] [diff] [review]
1324556-resonsiveUIKey.patch

> Sorry I lost track of this. I will see that it gets into 2.49.1

-<!ENTITY responsiveDesignTool.commandkey "M">

You might want to keep the above for 2.49 / comm-beta to keep localizers happy.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/84238bbd07ce
Remove command key for Responsive Design View. r=stefanh

Comment 13

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8895905 [details] [diff] [review]
1324556-resonsiveUIKey.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: new mail not opening on OSX using command key for it.
Testing completed (on m-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): trivial issue.
String changes made by this patch: none. push can be made without changes in webDeveloper.dtd

Comment 14

[Ian Neal]

Comment on attachment 8895905 [details] [diff] [review]
1324556-resonsiveUIKey.patch

a=me

Comment 15

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-beta/rev/4992420914fb7a09e3360042a2d6c5b5edbd93b9
https://hg.mozilla.org/releases/comm-esr52/rev/a5ae4ab67108250ec0a25172783c0a0fbb94685b

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bf911482c679
Remove undefined command key for Responsive Design View. r=frg

Comment 18

[Frank-Rainer Grahl (:frg)]

Followup in Comment 17 and 18:
https://hg.mozilla.org/releases/comm-esr60/rev/6f606bccc2528de8f4e3828acedfa4e464e930cc
Remove undefined command key for Responsive Design View. r=frg a=frg