Closed Bug 1324556 Opened 3 years ago Closed 3 years ago
new message keyboard shortcut not working
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46 Build ID: 20161005021738 Steps to reproduce: Create new profile. Start new profile in safe mode. Press Shift+Command+M Actual results: Nothing other than sometimes the Tools menu flashes, other times the File menu. Expected results: A new message composition window opens.
I'm 98% sure this was working fine in SM 2.40
Works under Windows with Ctrl-M. Stefan could you check it on OSX.
OS: Unspecified → Mac OS X
Yeah, looks like there's a conflict with the "Responsive Design View" key here... On trunk, hitting Cmd+Shift+M when the browser window is in front, I get this: ************************* A coding exception was thrown and uncaught in a Task. Full message: TypeError: aWindow.gBrowser.getBrowserContainer is not a function Full stack: ResponsiveUI@resource://devtools/client/responsivedesign/responsivedesign.jsm:172:20 Manager.openIfNeeded<@resource://devtools/client/responsivedesign/responsivedesign.jsm:79:12 _run@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:311:39 TaskImpl@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:273:3 asyncFunction@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:247:14 toggle@resource://devtools/client/responsivedesign/responsivedesign.jsm:65:7 toggle@chrome://navigator/content/webDeveloperOverlay.js:18:5 oncommand@chrome://navigator/content/navigator.xul:1:1 ************************* Now, looking at https://dxr.mozilla.org/comm-central/rev/9dff59feff428451f3cbf5d3fe0b7934153558d1/suite/browser/webDeveloperOverlay.xul#102 and https://dxr.mozilla.org/comm-central/rev/9dff59feff428451f3cbf5d3fe0b7934153558d1/suite/locales/en-US/chrome/browser/webDeveloper.dtd#22 the conflict is obvious. The funny thing is that the shortcut shown in the menuitem is Cmd+Alt+M which I guess comes from https://dxr.mozilla.org/mozilla-central/rev/1156db49e976173fc3cf90d2126456fd1e2bae4b/devtools/client/menus.js#140
Btw, the "new Message" shortcut works when the mail window is in front.
Status: UNCONFIRMED → NEW
Ever confirmed: true
A quick fix is to just remove the modifiers at https://dxr.mozilla.org/comm-central/rev/9dff59feff428451f3cbf5d3fe0b7934153558d1/suite/browser/webDeveloperOverlay.xul#102 (the menuitem "Responsive Design View" doesn't work at all for me, so it's no loss...).
Philip, see comment #3 and comment #5 - do you have any other suggestions?
(In reply to Stefan [:stefanh] from comment #5) > A quick fix is to just remove the modifiers at > https://dxr.mozilla.org/comm-central/rev/ > 9dff59feff428451f3cbf5d3fe0b7934153558d1/suite/browser/webDeveloperOverlay. > xul#102 (the menuitem "Responsive Design View" doesn't work at all for me, > so it's no loss...). Well yeah lets kill the "Responsive Design View" until we have a working RDV.
Keyboard shortcut still not working in 2.48
Sorry I lost track of this. I will see that it gets into 2.49.1
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attachment #8895903 - Flags: review?(stefanh)
oops wrong patch
Comment on attachment 8895905 [details] [diff] [review] 1324556-resonsiveUIKey.patch > Sorry I lost track of this. I will see that it gets into 2.49.1 -<!ENTITY responsiveDesignTool.commandkey "M"> You might want to keep the above for 2.49 / comm-beta to keep localizers happy.
Attachment #8895905 - Flags: review?(stefanh) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/comm-central/rev/84238bbd07ce Remove command key for Responsive Design View. r=stefanh
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Comment on attachment 8895905 [details] [diff] [review] 1324556-resonsiveUIKey.patch [Approval Request Comment] Regression caused by (bug #): -- User impact if declined: new mail not opening on OSX using command key for it. Testing completed (on m-c, etc.): c-c Risk to taking this patch (and alternatives if risky): trivial issue. String changes made by this patch: none. push can be made without changes in webDeveloper.dtd
Comment on attachment 8895905 [details] [diff] [review] 1324556-resonsiveUIKey.patch a=me
Pushed by email@example.com: https://hg.mozilla.org/comm-central/rev/bf911482c679 Remove undefined command key for Responsive Design View. r=frg
You need to log in before you can comment on or make changes to this bug.