1324565 - Stop using SDK page-mod for highlighter

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Alexandre Poirot [:ochameau]]

Here is a profile of inspector open:
  https://new.cleopatra.io/public/a59c998a9f498cfea7cb400e635faf1724471316/calltree/?jsOnly&search=installHelperSheet&thread=2

40ms in installHelperSheet mostly spent in loading sdk modules in the child process.
Clear the searchbox on cleapatra to see the whole profile, you will see that this naive function take a significant time to proceed, whereas the only code we have to call is nsIDOMWindowUtils.loadSheet, which we can see here:
https://new.cleopatra.io/public/a59c998a9f498cfea7cb400e635faf1724471316/calltree/?jsOnly&search=loadSheet&thread=2
And takes only 3ms...

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1324565 - Remove dependency to sdk/page-mod from inspector highlighter.

Review commit: https://reviewboard.mozilla.org/r/99572/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99572/

Comment 2

[Alexandre Poirot [:ochameau]]

Unfortunately, this win seems to go under DAMP precision and isn't reported as a win:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=152cd91f4ee6cd4f374474153e2c4d09d33ebb63&newProject=try&newRevision=af9d682e335a3b5e138f1a8265cdd01b687fe5ca&framework=1&showOnlyImportant=0

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8820041 [details]
Bug 1324565 - Remove dependency to sdk/page-mod from inspector highlighter.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99572/diff/1-2/

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0553572ee113

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 8820041 [details]
Bug 1324565 - Remove dependency to sdk/page-mod from inspector highlighter.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99572/diff/2-3/

Comment 6

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2d31a47a69b

Comment 7

[Alexandre Poirot [:ochameau]]

Comment on attachment 8820041 [details]
Bug 1324565 - Remove dependency to sdk/page-mod from inspector highlighter.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99572/diff/3-4/

Comment 8

[Patrick Brosset <:pbro>]

Sorry Alex, I'm going away for a couple of weeks and won't have time to review this change before. Feel free to ask someone else for a review if you want it done sooner.

Comment 9

[Patrick Brosset <:pbro>]

Comment on attachment 8820041 [details]
Bug 1324565 - Remove dependency to sdk/page-mod from inspector highlighter.

https://reviewboard.mozilla.org/r/99572/#review103820

Comment 10

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fbf1ba06cac
Remove dependency to sdk/page-mod from inspector highlighter. r=pbro

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5fbf1ba06cac