IMPLEMENTATION_COLOR_READ_FORMAT/TYPE queries generate unexpected error on OSX+NV

RESOLVED FIXED in Firefox 51

Status

()

Product:
Core
Component:
Canvas: WebGL
Importance:
P1
normal
Status:
RESOLVED FIXED
Reported:
2 years ago
Modified:
2 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

Version:
unspecified
Target:
mozilla53
Points:
---

Firefox Tracking Flags

(firefox51 fixed, firefox52 fixed, firefox53 fixed)

Details

(Whiteboard: gfx-noted)

Attachments

(2 attachments)

Bug 1324604 - Only query IMPLEMENTATION_COLOR_READ_FORMAT/TYPE on actual GLES. -
58 bytes, text/x-review-board-request
daoshengmu
: review+
gchang
: approval-mozilla-aurora+
gchang
: approval-mozilla-beta+
Details
Bug 1324604 - Remark tests.
58 bytes, text/x-review-board-request
Details
(Assignee)

Description

•
2 years ago 
The ES2_compat GL extension is supposed to allow this query, but is actually spec'd to always return RGBA/UNSIGNED_BYTE. It looks like we should just ignore these queries except on actual GLES.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

•
2 years ago
mozreview-review 
Comment on attachment 8820088 [details]
Bug 1324604 - Only query IMPLEMENTATION_COLOR_READ_FORMAT/TYPE on actual GLES. -

https://reviewboard.mozilla.org/r/99612/#review100072

LGTM
Attachment #8820088 - Flags: review?(dmu) → review+
Comment hidden (mozreview-request)

Comment 5

•
2 years ago 
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45d134d04971
Only query IMPLEMENTATION_COLOR_READ_FORMAT/TYPE on actual GLES. (flattened) - r=daoshengmu

Comment 6

•
2 years ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/45d134d04971
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(Assignee)

Comment 7

•
2 years ago 
Comment on attachment 8820088 [details]
Bug 1324604 - Only query IMPLEMENTATION_COLOR_READ_FORMAT/TYPE on actual GLES. -

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:
Attachment #8820088 - Flags: approval-mozilla-beta?
Attachment #8820088 - Flags: approval-mozilla-aurora?
status-firefox51: --- → affected
status-firefox52: --- → affected

Comment 8

•
2 years ago 
Comment on attachment 8820088 [details]
Bug 1324604 - Only query IMPLEMENTATION_COLOR_READ_FORMAT/TYPE on actual GLES. -

Fix WebGL2 related issue. Beta51+ & Aurora52+. Should be in 51 beta 10.
Attachment #8820088 - Flags: approval-mozilla-beta?
Attachment #8820088 - Flags: approval-mozilla-beta+
Attachment #8820088 - Flags: approval-mozilla-aurora?
Attachment #8820088 - Flags: approval-mozilla-aurora+

Comment 9

•
2 years ago 
Check-in: https://hg.mozilla.org/releases/mozilla-aurora/rev/1c27570771fc
status-firefox52: affected → fixed
You need to log in before you can comment on or make changes to this bug.