[jsplugins] merge unit test into m-c

RESOLVED FIXED in Firefox 54

Status

()

Firefox
PDF Viewer
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Ya-Chieh Wu (inactive), Assigned: Ya-Chieh Wu (inactive))

Tracking

(Blocks: 1 bug)

unspecified
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
When we merge unit test into m-c, we at least need to do 2 things

(1) Put XPCSHELL_TESTS_MANIFESTS into moz.build
XPCSHELL_TESTS_MANIFESTS += ['test/unit/xpcshell.ini']
(2) Change the path of the "ppapi.js" in addon to the exact file path.
(Assignee)

Comment 1

2 years ago
Created attachment 8835814 [details] [diff] [review]
Bug 1324622 - merge unit test

This patch is our first version of unit test.

(1) run xpcshell
  ./mach xpcshell-test browser/extensions/mortar/your-path-to-the-test-file

(2) how to write a test file
  1. easily create testcases from PPB_* logs 
  2. mock test input for testcases 
  3. pass testcases into |Call_PpbFunc| will call the PPB_* API implementation 
     in ppapi-runtime.jsm
Attachment #8835814 - Flags: review?(ehung)

Comment 2

2 years ago
Comment on attachment 8835814 [details] [diff] [review]
Bug 1324622 - merge unit test

LGTM. Thanks.
Attachment #8835814 - Flags: review?(ehung) → review+

Updated

2 years ago
Group: mozilla-employee-confidential
(Assignee)

Comment 3

2 years ago
Created attachment 8835890 [details] [diff] [review]
Bug 1324622-merge unit test into mortar. r=ehung.

thank you Evelyn for reviewing.

Result of the try server:
 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b167415b07d8a1f8b1ed6f767fff4582cb0840d
Attachment #8835814 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65df996e64fa
merge unit test into mortar. r=ehung
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/65df996e64fa
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.