Closed
Bug 1324622
Opened 6 years ago
Closed 6 years ago
[jsplugins] merge unit test into m-c
Categories
(Firefox :: PDF Viewer, defect)
Firefox
PDF Viewer
Tracking
()
RESOLVED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: ywu, Assigned: ywu)
References
Details
Attachments
(1 file, 1 obsolete file)
6.04 KB,
patch
|
Details | Diff | Splinter Review |
When we merge unit test into m-c, we at least need to do 2 things (1) Put XPCSHELL_TESTS_MANIFESTS into moz.build XPCSHELL_TESTS_MANIFESTS += ['test/unit/xpcshell.ini'] (2) Change the path of the "ppapi.js" in addon to the exact file path.
Assignee | ||
Comment 1•6 years ago
|
||
This patch is our first version of unit test. (1) run xpcshell ./mach xpcshell-test browser/extensions/mortar/your-path-to-the-test-file (2) how to write a test file 1. easily create testcases from PPB_* logs 2. mock test input for testcases 3. pass testcases into |Call_PpbFunc| will call the PPB_* API implementation in ppapi-runtime.jsm
Attachment #8835814 -
Flags: review?(ehung)
Comment 2•6 years ago
|
||
Comment on attachment 8835814 [details] [diff] [review] Bug 1324622 - merge unit test LGTM. Thanks.
Attachment #8835814 -
Flags: review?(ehung) → review+
Updated•6 years ago
|
Group: mozilla-employee-confidential
Assignee | ||
Comment 3•6 years ago
|
||
thank you Evelyn for reviewing. Result of the try server: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b167415b07d8a1f8b1ed6f767fff4582cb0840d
Attachment #8835814 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/65df996e64fa merge unit test into mortar. r=ehung
Keywords: checkin-needed
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/65df996e64fa
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in
before you can comment on or make changes to this bug.
Description
•