Closed Bug 1324622 Opened 6 years ago Closed 6 years ago

[jsplugins] merge unit test into m-c

Categories

(Firefox :: PDF Viewer, defect)

Product:
Firefox
Component:
PDF Viewer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: ywu, Assigned: ywu)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1324622-merge unit test into mortar. r=ehung.
6.04 KB, patch
Details | Diff | Splinter Review 
When we merge unit test into m-c, we at least need to do 2 things

(1) Put XPCSHELL_TESTS_MANIFESTS into moz.build
XPCSHELL_TESTS_MANIFESTS += ['test/unit/xpcshell.ini']
(2) Change the path of the "ppapi.js" in addon to the exact file path.
Attached patch Bug 1324622 - merge unit test (obsolete) — — Splinter Review 
This patch is our first version of unit test.

(1) run xpcshell
  ./mach xpcshell-test browser/extensions/mortar/your-path-to-the-test-file

(2) how to write a test file
  1. easily create testcases from PPB_* logs 
  2. mock test input for testcases 
  3. pass testcases into |Call_PpbFunc| will call the PPB_* API implementation 
     in ppapi-runtime.jsm
Attachment #8835814 - Flags: review?(ehung)
Comment on attachment 8835814 [details] [diff] [review]
Bug 1324622 - merge unit test

LGTM. Thanks.
Attachment #8835814 - Flags: review?(ehung) → review+
Group: mozilla-employee-confidential
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/65df996e64fa
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.