stylo: mark currently failing crashtests as asserts-if(stylo,...)

RESOLVED FIXED in Firefox 53

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

(Blocks: 1 bug)

unspecified
mozilla53
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
To get the crashtest job green, in this bug I'll mark the tests that are currently failing (due to non-fatal assertions) as fails-if(stylo).  I'll file bugs for fixing the underlying issues and removing the fails-if annotation blocking bug 1324620.
(Assignee)

Comment 1

a year ago
Better to mark the specific number of assertions we expect.
Summary: stylo: mark currently failing crashtests as fails-if(stylo) → stylo: mark currently failing crashtests as asserts-if(stylo,...)
(Assignee)

Comment 3

a year ago
Doing one more round of tests to see if there are any more fluctuating assertion counts to account for: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b919564f39ad5b1d437d5a0f61b55d732fe8351

Some of those are due to bug 1324983, so for those I won't bother trying to annotate since they could turn up in any test.
(Assignee)

Comment 4

a year ago
Created attachment 8820545 [details] [diff] [review]
patch
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8820545 - Flags: review?(xidorn+moz)
Comment on attachment 8820545 [details] [diff] [review]
patch

Review of attachment 8820545 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

So many assertions... would we eventually get to fixing all of them? :-/
Attachment #8820545 - Flags: review?(xidorn+moz) → review+
(Assignee)

Comment 6

a year ago
I think we have to!  At least, most of them seem to be real problems we need to fix.  I've grouped them by the specific sets of assertions that were fired in the bugs blocking bug 1324620, so it's certainly not as bad as a new investigation needed for each test that I've annotated.

Comment 7

a year ago
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9084fa685374
stylo: Mark currently failing crashtests with asserts-if(stylo,...). r=xidorn

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9084fa685374
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Comment 9

a year ago
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07a8f320d6a5
Tweak stylo crashtest assertion annotations a bit more.

Comment 11

a year ago
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fac6778e2dc3
stylo: More crashtest assertion adjustments.
Comment on attachment 8820545 [details] [diff] [review]
patch

Review of attachment 8820545 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/crashtests/crashtests.list
@@ +631,4 @@
>  load 1233191.html
> +asserts-if(stylo,16) load 1271765.html # bug 1324684
> +asserts(2) load 1272983-1.html # bug 1324654 # bug 586628
> +asserts(2) load 1272983-2.html # bug 1324654 # bug 586628

These ^^ last two lines weren't intended to land, I think -- the "# bug 1324654 # bug 586628" is redundant because both bugs are about the same issue. (And bug 1324654 was resolved as INVALID as a result.)

I'll push a trivial followup to revert this part of the change.

(Just ran across this when adding some other stuff to crashtests.list and noticing the double-comment here.)

Comment 14

a year ago
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e74b404c3cd
followup: Remove bogus/redundant crashtest comment for invalid bug 1324654. (no review, comment-only, DONTBUILD)
You need to log in before you can comment on or make changes to this bug.