1324624 - stylo: mark currently failing crashtests as asserts-if(stylo,...)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

To get the crashtest job green, in this bug I'll mark the tests that are currently failing (due to non-fatal assertions) as fails-if(stylo).  I'll file bugs for fixing the underlying issues and removing the fails-if annotation blocking bug 1324620.

Comment 1

[Cameron McCormack (:heycam)]

Better to mark the specific number of assertions we expect.

Comment 2

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=54cd1c50009547a2f92ce0fd36d11509cc075df5

Comment 3

[Cameron McCormack (:heycam)]

Doing one more round of tests to see if there are any more fluctuating assertion counts to account for: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b919564f39ad5b1d437d5a0f61b55d732fe8351

Some of those are due to bug 1324983, so for those I won't bother trying to annotate since they could turn up in any test.

Comment 4

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8820545 [details] [diff] [review]
patch

Review of attachment 8820545 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

So many assertions... would we eventually get to fixing all of them? :-/

Comment 6

[Cameron McCormack (:heycam)]

I think we have to!  At least, most of them seem to be real problems we need to fix.  I've grouped them by the specific sets of assertions that were fired in the bugs blocking bug 1324620, so it's certainly not as bad as a new investigation needed for each test that I've annotated.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9084fa685374
stylo: Mark currently failing crashtests with asserts-if(stylo,...). r=xidorn

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9084fa685374

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07a8f320d6a5
Tweak stylo crashtest assertion annotations a bit more.

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/07a8f320d6a5

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fac6778e2dc3
stylo: More crashtest assertion adjustments.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fac6778e2dc3

Comment 13

[Daniel Holbert [:dholbert]]

Comment on attachment 8820545 [details] [diff] [review]
patch

Review of attachment 8820545 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/crashtests/crashtests.list
@@ +631,4 @@
>  load 1233191.html
> +asserts-if(stylo,16) load 1271765.html # bug 1324684
> +asserts(2) load 1272983-1.html # bug 1324654 # bug 586628
> +asserts(2) load 1272983-2.html # bug 1324654 # bug 586628

These ^^ last two lines weren't intended to land, I think -- the "# bug 1324654 # bug 586628" is redundant because both bugs are about the same issue. (And bug 1324654 was resolved as INVALID as a result.)

I'll push a trivial followup to revert this part of the change.

(Just ran across this when adding some other stuff to crashtests.list and noticing the double-comment here.)

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e74b404c3cd
followup: Remove bogus/redundant crashtest comment for invalid bug 1324654. (no review, comment-only, DONTBUILD)

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9e74b404c3cd