Closed Bug 1324629 Opened 3 years ago Closed 3 years ago

Change MediaDecoderReaderWrapper::Request{Audio,Video}Data() to be promise-based intead of callback-based

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(5 files)

Thanks to bug 1318610, we are now able to remove callbacks and use promise instead.
Assignee: nobody → jwwang
Depends on: 1318610
Priority: -- → P3
Comment on attachment 8821006 [details]
Bug 1324629. Part 1 - remove audio callback.

https://reviewboard.mozilla.org/r/100378/#review101460
Attachment #8821006 - Flags: review?(kaku) → review+
Comment on attachment 8821007 [details]
Bug 1324629. Part 2 - remove video callback.

https://reviewboard.mozilla.org/r/100380/#review101462
Attachment #8821007 - Flags: review?(kaku) → review+
Comment on attachment 8821008 [details]
Bug 1324629. Part 3 - remove AudioWait and videoWait callbacks.

https://reviewboard.mozilla.org/r/100382/#review101464
Attachment #8821008 - Flags: review?(kaku) → review+
Comment on attachment 8821009 [details]
Bug 1324629. Part 4 - clean up some functions and comments.

https://reviewboard.mozilla.org/r/100384/#review101466
Attachment #8821009 - Flags: review?(kaku) → review+
Comment on attachment 8821053 [details]
Bug 1324629. Part 5 - replace some member functions with lambda.

https://reviewboard.mozilla.org/r/100436/#review101468
Attachment #8821053 - Flags: review?(kaku) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b731571bbb25
Part 1 - remove audio callback. r=kaku
https://hg.mozilla.org/integration/autoland/rev/e093fc2ce534
Part 2 - remove video callback. r=kaku
https://hg.mozilla.org/integration/autoland/rev/a8b293c96e06
Part 3 - remove AudioWait and videoWait callbacks. r=kaku
https://hg.mozilla.org/integration/autoland/rev/075a9bac75bd
Part 4 - clean up some functions and comments. r=kaku
https://hg.mozilla.org/integration/autoland/rev/ec26804c2b7d
Part 5 - replace some member functions with lambda. r=kaku
You need to log in before you can comment on or make changes to this bug.