132467 - save page as format option not remembered on mac

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2002.03.20.08 comm verif bits on mac 10.1.3. looks like the filter
option selected is not remembered --it always has "web page, complete" selected.

this is not a problem on linux or win2k. will check on mac 9.x later on.

1. go to a web page, eg, http://mozilla.org/
2. hit cmd+S or select File > Save Page As.
3. note that the resulting file picker dlg has "web page, complete" selected for
the "Format" option droplist. change this to something else --either "web page,
HTML only" or "Text".
4. save the file.
5. go to another page, or stay at the same page --doesn't really matter-- and
repeat step (2).

expected: the file picker should have whatever format option you had selected in
step (3).

actual results: the file picker still lists "web page, complete".

Comment 1

[sairuh (rarely reading bugmail)]

also a problem on mac 9.1 (2002.03.20.08 comm bits over classic emulation).

Comment 2

[Steve Dagley]

Unless there is a strong argument for having this work I'm inclined to WONTFIX
or FUTURE it.  I know how to make it work on Mac OS 9 but not on OS X (the docs
for the Nav Services 3.0 changes in OS X/Carbon, in a word, suck).

Comment 3

[Boris Zbarsky [:bzbarsky]]

The strong argument is that the default option doesn't save the actual source of
the page and so causes dataloss when used in conjunction with composer....

Comment 4

[sairuh (rarely reading bugmail)]

well, if it is fixable, i'd rather not mark this wontfix --esp since it can be
done in 9.x. :) adding helpwanted...

Comment 5

[Steve Dagley]

I'm confused by the comment "the default option doesn't save the actual source of
the page" - I thought the default was to save _everything_ on the page (html
source and images)?

Comment 6

[Boris Zbarsky [:bzbarsky]]

It saves "everything" in that the result looks pretty much like what the page
looks like (unless the page has embedded scripts).

The problem is that it saves a serialization of the DOM, not the source.  That
means that whitespace is changed, errors in the source are "fixed", etc. 
Furthermore, it changes image src attributes, body background attributes, and so
forth, to point to local copies of the images.

In other words, saving an HTML page using "save page, complete" and then
uploading it back up via ftp, for example, would not work at all.

Comment 7

[Steve Dagley]

Boris, thanks for the explanation, now I understand the severity.  I'll take a
look at the fix for OS 9 and try a WAG at the Nav Services 3 version.

Comment 8

[Steve Dagley]

Attachment: Patch to pre-select a Format menu item

This patch seems to work for Nav Services 3.0/Carbon, posting so I can apply it
to a Classic build.

Comment 9

[Steve Dagley]

Verified in Classic build as well.  Not that there's any documentation to this
effect but testing would indicate you don't actually have to pass the text of
the menu item into the call to pre-select the Format menu item.  That's a Good
Thing™ since in Carbon the menu items are CFStrings while under Classic they're
Str255s.  Have I mentioned how much I dislike Nav Services recently?

r/sr please

Comment 10

[Steve Dagley]

Let me rephrase that disparaging comment on Nav Services - it'd be more accurate
to comment on the sad state of Nav Services 3.0 documentation and sample code. 
Having Nav Services 3.0 support Unicode is actually kinda nice.

Comment 11

[Conrad Carlen (not reading bugmail)]

Comment on attachment 75524 [details] [diff] [review]
Patch to pre-select a Format menu item

r=ccarlen

Comment 12

[Simon Fraser [no longer active]]

Comment on attachment 75524 [details] [diff] [review]
Patch to pre-select a Format menu item

sr=sfraser

Comment 13

[Scott Collins]

Comment on attachment 75524 [details] [diff] [review]
Patch to pre-select a Format menu item

a=scc

Comment 14

[Steve Dagley]

Fix checked in

Comment 15

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2002.03.26.08 comm bits on mac 10.1.3 and 9.1 (emulation).