1324722 - Relocate Mozilla.Cookies helper to common.js bundle

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Alex Gibson [:agibson]]

In the event of our upcoming stub attribution work, the usage of cookies on bedrock is going to evolve past ad-hock A/B experiments with Traffic Cop, and could be required by pretty much any page on the site. As recently discussed in our PR triage, I think it makes sense to move our Mozilla.Cookies JS helper into the common.js bundle to make it available on all pages.

We also recently added-in a cookies feature detect that is in use on the home page [1]. I think it would make sense to move this function to the cookie helper itself, so we can reuse it on other pages when needed.

[1] https://github.com/mozilla/bedrock/blob/master/media/js/mozorg/home/takeover-2016.js#L40-L53

Comment 1

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/0e4eeada4954f20d9cdbcd3308c289cf2c8d5db9
[fix bug 1324722] Relocate Mozilla.Cookies helper to site.js bundle

https://github.com/mozilla/bedrock/commit/91a758af26ac6b40f34762cb6c0b1ac9f86bd15d
Merge pull request #4534 from alexgibson/relocate-cookie-helper-js

[fix bug 1324722] Relocate Mozilla.Cookies helper to site.js bundle