1324727 - Assert in generated/test_2_conformance2__textures__misc__tex-image-with-bad-args-from-dom-elements.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Vincent Liu[:vliu]]

[1] was the try result. The crash happens on OS X 10.10 debug Mochitest Mochitest WebGL M(gl1). Please see [2] for more details.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfd5a67c5d9b92ea54bc00495e4a17052f4b0e52&selectedJob=33072185

[2]: https://treeherder.mozilla.org/logviewer.html#?job_id=33072185&repo=try

Comment 1

[Kelsey Gilbert [:jgilbert]]

We don't have a WebGLTexelFormat for RGB10_A2, which triggers an assert.

Fortunately, we don't need to:
https://www.khronos.org/registry/webgl/specs/latest/2.0/#TEXTURE_TYPES_FORMATS_FROM_DOM_ELEMENTS_TABLE

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1324727 - Check for invalid DOM upload format/type. -

Review commit: https://reviewboard.mozilla.org/r/99932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99932/

Comment 3

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8820441 [details]
Bug 1324727 - Check for invalid DOM upload format/type. -

https://reviewboard.mozilla.org/r/99932/#review100476

LGTM

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8820441 [details]
Bug 1324727 - Check for invalid DOM upload format/type. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99932/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98e30fd3f0c2
Check for invalid DOM upload format/type. - r=daoshengmu

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/98e30fd3f0c2

Comment 7

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/873e56b03a26

Comment 8

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1099ef60cc58