Closed Bug 1324727 Opened 4 years ago Closed 4 years ago

Assert in generated/test_2_conformance2__textures__misc__tex-image-with-bad-args-from-dom-elements.html

Categories

(Core :: Canvas: WebGL, defect, P1)

Unspecified
All
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox51 --- fixed
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: vliu, Assigned: jgilbert)

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

[1] was the try result. The crash happens on OS X 10.10 debug Mochitest Mochitest WebGL M(gl1). Please see [2] for more details.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfd5a67c5d9b92ea54bc00495e4a17052f4b0e52&selectedJob=33072185

[2]: https://treeherder.mozilla.org/logviewer.html#?job_id=33072185&repo=try
We don't have a WebGLTexelFormat for RGB10_A2, which triggers an assert.

Fortunately, we don't need to:
https://www.khronos.org/registry/webgl/specs/latest/2.0/#TEXTURE_TYPES_FORMATS_FROM_DOM_ELEMENTS_TABLE
Assignee: nobody → jgilbert
OS: Unspecified → All
Priority: -- → P1
Whiteboard: gfx-noted
Summary: Crash in generated/test_2_conformance2__textures__misc__tex-image-with-bad-args-from-dom-elements.html → Assert in generated/test_2_conformance2__textures__misc__tex-image-with-bad-args-from-dom-elements.html
Comment on attachment 8820441 [details]
Bug 1324727 - Check for invalid DOM upload format/type. -

https://reviewboard.mozilla.org/r/99932/#review100476

LGTM
Attachment #8820441 - Flags: review?(dmu) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98e30fd3f0c2
Check for invalid DOM upload format/type. - r=daoshengmu
https://hg.mozilla.org/mozilla-central/rev/98e30fd3f0c2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.