1324763 - Make symbol upload logic for nightlies suitable for landing on mozilla-central

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Justin Wood (:Callek)]

+++ This bug was initially created as a clone of Bug #1322041 +++

Kim, can you please address the following review comment(s) and flag dustin for review.

Once reviewed for changes land on date and I'll incorporate into the m-c landing bug 1322041.

(In reply to Dustin J. Mitchell [:dustin] from comment #102)
> Comment on attachment 8816762 [details]
> Bug 1322041 - Upload nightly symbols.
> 
> https://reviewboard.mozilla.org/r/97334/#review99946
> 
> ::: taskcluster/taskgraph/transforms/upload_symbols.py:34
> (Diff revisions 7 - 8)
> >          treeherder = task.get('treeherder', {})
> >          treeherder.setdefault('symbol', 'tc(Sym)')
> > -        if 'android' in build_platform:
> > +        if 'android-api-15' in build_platform:
> >              treeherder.setdefault('platform', "{}/opt".format("android-4-0-armv7-api15"))
> > +        elif 'android-x86' in build_platform:
> > +            treeherder.setdefault('platform', "{}/opt".format("android-4-2-x86"))
> >          elif build_platform == "linux-nightly":
> >              treeherder.setdefault('platform', "{}/opt".format("linux32"))
> >          else:
> >              treeherder.setdefault('platform',
> >                                    "{}/opt".format(build_platform).replace("-nightly", ""))
> >          treeherder.setdefault('tier', 2)
> >          treeherder.setdefault('kind', 'build')
> >          task['treeherder'] = treeherder
> 
> I think all of this is basically re-implementing the config in
> `taskcluster/ci/build/android.yml`:
> 
>     android-api-15/debug:
>         ...
>         treeherder:
>             platform: android-4-0-armv7-api15/debug
> 
>     ...
>     android-x86/opt:
>         ...
>         treeherder:
>             platform: android-4-2-x86/opt
> 
> Along with bits of the config in `linux.yml` I suppose.
> 
> Instead, why not just modify `post_build.py` to pass the whole build task,
> and copy its `extra.treeherder` over verbatim, changing just the symbol?

Comment 1

[Kim Moir [:kmoir] ET]

Yes, I'll do this

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

I'm open to other approaches, too, and happy to chat about the options.

Comment 3

[Kim Moir [:kmoir] ET]

Attachment: bug1324763.patch

Comment 4

[Kim Moir [:kmoir] ET]

Comment on attachment 8820390 [details] [diff] [review]
bug1324763.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a80b3298006b711d4ded9f1eb1650393ce7512b&selectedJob=33136055

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8820390 [details] [diff] [review]
bug1324763.patch

Review of attachment 8820390 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome to see all that special-casing go away :)

::: taskcluster/taskgraph/transforms/upload_symbols.py
@@ +32,5 @@
>              attributes['nightly'] = True
>          treeherder = task.get('treeherder', {})
> +        th = task['build-task'].task.get('extra')['treeherder']
> +        treeherder.setdefault('platform',
> +                              "{}/opt".format(th['machine']['platform']))

This implies that symbols are only uploaded for opt builds, and would probably mis-assign a platform for e.g., an asan build.  That's OK for now, and hopefully bug 1286086 would clean it up.

Comment 6

[Kim Moir [:kmoir] ET]

Comment on attachment 8820390 [details] [diff] [review]
bug1324763.patch

https://hg.mozilla.org/projects/date/rev/89df88ad61aebf634cabd2343bfe4e2aba175ade

Comment 7

[Kim Moir [:kmoir] ET]

Attachment: lint.patch

patch to fix lint error, I landed it on date