Closed Bug 1324777 Opened 3 years ago Closed 3 years ago

--disable-rust breaks when specifying --disable-compile-environment

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX
mozilla53

People

(Reporter: Pike, Unassigned)

References

Details

I'd think that --disable-rust should be probably a no-op when specifying --disable-compile-environment.

Right now, it fails with a 

 0:03.95 mozbuild.configure.options.InvalidOptionError: --disable-rust is not available in this configuration

This breaks the mac thunderbird nightlies, which specify both. I can also reproduce with the following .mozconfig on firefox, though:

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-firefox-repack
ac_add_options --with-l10n-base=/src/central/l10n-central/
ac_add_options --enable-application=browser
ac_add_options --with-macbundlename-prefix=Firefox
ac_add_options --disable-compile-environment
ac_add_options --disable-rust
The rationale here, AIUI, is that you've specifically requested that you don't care about compiling code with --disable-compile-environment.  So any options that deal with compilation are pointless to specify.  We've dealt with this already when trying to --enable-rust everywhere: we had to be careful with artifact builds (--disable-compile-environment) and the like.

The mac thunderbird nightly mozconfigs should be fixed.
Depends on: 1324027
https://hg.mozilla.org/comm-central/rev/84c6ff29b0d4f29c8f017ce27ceb80c674913678
Bug 1324777 - --disable-rust not needed when specifying --disable-compile-environment. rs=bustage-fix
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.