Closed
Bug 1324855
Opened 7 years ago
Closed 7 years ago
h2 telemetry on continued header size for quic dev
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: mcmanus, Assigned: mcmanus)
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
5.35 KB,
patch
|
benjamin
:
review+
u408661
:
review+
|
Details | Diff | Splinter Review |
https://github.com/quicwg/base-drafts/issues/76#issuecomment-265943121 the quic design might be able to get rid of the h2 continuation scheme if we're confident there isn't an absurd tail on the distribution of continuted headers in h2. add telemetry to find out.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → mcmanus
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8f592437570
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8820369 -
Flags: review?(benjamin)
Assignee | ||
Updated•7 years ago
|
Attachment #8820369 -
Flags: review?(hurley)
Comment on attachment 8820369 [details] [diff] [review] H2 telemetry for continued header sizes Review of attachment 8820369 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me for what it is. However, do we also want to get telemetry on the ratio of continued headers vs. non-continued headers? (Not header size, just what percentage do we see continuation vs. what percentage do we not see continuation.) That seems like it could be useful for making this determination, as well.
Attachment #8820369 -
Flags: review?(hurley) → review+
Assignee | ||
Comment 4•7 years ago
|
||
no.. we really just want to know what the tail value is to see if we can just go with a bigger frame and no continuation mechanism.
Updated•7 years ago
|
Whiteboard: [necko-active]
Comment 5•7 years ago
|
||
Comment on attachment 8820369 [details] [diff] [review] H2 telemetry for continued header sizes For those of us who don't know anything about SPDY (and people who don't know that SPDY is a networking thing), it might be useful to add an extra sentence to the histogram description telling us that this is a network metric for the SPDY protocol, and tell us when this will be recorded; e.g. is this a per request metric or a per connection or frame or something else? That way we'll end up with less confusing telemetry docs. data-r=me
Attachment #8820369 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3957966793a4540f45372af9fb891bfdb7580381 Bug 1324855 - H2 telemetry for continued header sizes r=hurley r=bsmedberg
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3957966793a4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•