|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
The mach vendor rust command fails on MacOS 10.12 installing `cargo-vendor` because it uses openssl-sys as a dependendency, but MacOS no longer provides a system version. It's common to have homebrew install a version in /usr/local/opt/openssl/ but special flags are needed to access this. I think we should check for this case and have mach supply the relevant flags.
I wonder if we should add openssl to the bootstrap package list on osx too. Saves a step for now, but I expect this to get fixed upstream soon; the openssl-sys dep has been broken for several MacOS releases now.
Assignee: nobody → giles
Comment on attachment 8820378 [details] Bug 1324869 - Make 'mach vendor rust' work with Homebrew OpenSSL. https://reviewboard.mozilla.org/r/99878/#review100378 I'm going to trust that you got all the paths right and tested this locally.
Attachment #8820378 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #3) > I'm going to trust that you got all the paths right and tested this locally. Thanks. I tested on Mac and Linux, but not Windows. I left the not-found case as a warning in the hope we'd not break anyone's non-standard config. Pushed some typo fixes, carrying r=froydnj.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/d721b28ee3e6 Make 'mach vendor rust' work with Homebrew OpenSSL. r=froydnj
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.