1324894 - remove the PR_Interrupt call in BackgroundHangMonitor

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Nathan Froyd [:froydnj]]

This call makes BackgroundHangMonitor depend on internal implementation details of PRThread and NSPR's synchronization code in ways that I'd really rather not.  Having this call makes it difficult to get rid of using NSPR's synchronization primitives.

How strongly do you feel about a lock being taken here?

http://dxr.mozilla.org/mozilla-central/source/xpcom/threads/BackgroundHangMonitor.cpp#100

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

We already take mLock when Wakeup() is called, so this could be as simple as changing PR_Interrupt to lock.Notify(), and shouldn't make that big of a difference.

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Jim Chen [:jchen] [:darchons] from comment #1)
> We already take mLock when Wakeup() is called, so this could be as simple as
> changing PR_Interrupt to lock.Notify(), and shouldn't make that big of a
> difference.

Oh my, we do, don't we?  Sheesh.  Well, forget that, we'll just use the ordinary mechanism here.

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: use standard Monitor APIs rather than PR_Interrupt in BackgroundHangMonitor

Using PR_Interrupt here makes life difficult for other things, such as
moving away from NSPR synchronization primitives.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f42a80cee03
use standard Monitor APIs rather than PR_Interrupt in BackgroundHangMonitor; r=darchons

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5f42a80cee03