Add 'Open All in Tabs' to client context menu in Synced Tabs

RESOLVED FIXED in Firefox 53

Status

()

Firefox
Sync
P1
normal
RESOLVED FIXED
8 months ago
5 months ago

People

(Reporter: tabmix.onemen, Assigned: eoger)

Tracking

unspecified
Firefox 53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
The UI for Synced Tabs sidebar should be the same as the UI for Bookmarks and History sidebars.

One thing is missing know is 'Open All in Tabs'

This will enable users to use context menu on 'client' item to open all synced tabs in new tabs without having to use middle-click or ctrl-click

Updated

8 months ago
Assignee: nobody → eoger
Priority: -- → P1
(Assignee)

Updated

8 months ago
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

7 months ago
mozreview-review
Comment on attachment 8824190 [details]
Bug 1324895 - Add 'Open All in Tabs' to client context menu in Synced Tabs.

https://reviewboard.mozilla.org/r/102718/#review104426

Looks great, thanks!

::: browser/locales/en-US/chrome/browser/browser.dtd:761
(Diff revision 1)
>       when Sync is configured but syncing tabs is disabled. -->
>  <!ENTITY syncedTabs.sidebar.tabsnotsyncing.label       "Turn on tab syncing to view a list of tabs from your other devices.">
>  
>  <!ENTITY syncedTabs.context.open.label                       "Open">
>  <!ENTITY syncedTabs.context.open.accesskey                   "O">
> +<!ENTITY syncedTabs.context.openAllInTabs.label              "Open All in Tabs">

ISTM that "Open" and "Open All in Tabs" are mutually exclusive, so could share the same access key of "O", which would mean the access key is the same as the bookmarks sidebar.

If that's true and possible, please adjust the comments here accordingly so localizers know they can use the same access key for their locale - it might also make sense to move it outside this group of strings to make it even clearer which items appear together and which don't.
Attachment #8824190 - Flags: review?(markh) → review+
Comment hidden (mozreview-request)

Comment 4

7 months ago
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b485d4522a9b
Add 'Open All in Tabs' to client context menu in Synced Tabs. r=markh

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b485d4522a9b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.