1324895 - Add 'Open All in Tabs' to client context menu in Synced Tabs

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[tabmix.onemen]

The UI for Synced Tabs sidebar should be the same as the UI for Bookmarks and History sidebars.

One thing is missing know is 'Open All in Tabs'

This will enable users to use context menu on 'client' item to open all synced tabs in new tabs without having to use middle-click or ctrl-click

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1324895 - Add 'Open All in Tabs' to client context menu in Synced Tabs.

Review commit: https://reviewboard.mozilla.org/r/102718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102718/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8824190 [details]
Bug 1324895 - Add 'Open All in Tabs' to client context menu in Synced Tabs.

https://reviewboard.mozilla.org/r/102718/#review104426

Looks great, thanks!

::: browser/locales/en-US/chrome/browser/browser.dtd:761
(Diff revision 1)
>       when Sync is configured but syncing tabs is disabled. -->
>  <!ENTITY syncedTabs.sidebar.tabsnotsyncing.label       "Turn on tab syncing to view a list of tabs from your other devices.">
>  
>  <!ENTITY syncedTabs.context.open.label                       "Open">
>  <!ENTITY syncedTabs.context.open.accesskey                   "O">
> +<!ENTITY syncedTabs.context.openAllInTabs.label              "Open All in Tabs">

ISTM that "Open" and "Open All in Tabs" are mutually exclusive, so could share the same access key of "O", which would mean the access key is the same as the bookmarks sidebar.

If that's true and possible, please adjust the comments here accordingly so localizers know they can use the same access key for their locale - it might also make sense to move it outside this group of strings to make it even clearer which items appear together and which don't.

Comment 3

[Edouard Oger [:eoger]]

Comment on attachment 8824190 [details]
Bug 1324895 - Add 'Open All in Tabs' to client context menu in Synced Tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/102718/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b485d4522a9b
Add 'Open All in Tabs' to client context menu in Synced Tabs. r=markh

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b485d4522a9b

Comment 6

[Moises Lejter]

I don't see this option in Firefox 55.0.2 on Linux 64-bit...