1324936 - [Pontoon] Linkify Resource path

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P2)

Description

[Tomer Cohen :tomer]

When viewing search results or All Resources, sometimes I wish to know on which resource this string is declared. There is the Resource path at the end of the source panel, but I'll suggest linking it back to the resource, so we could easily jump from All Resources to the specified resource in order to pay more attention to similar strings. 

Currently this is done manually, but projects with multiple resources such as Firefox make it very difficult to locate the right resource each time.

Comment 1

[Tomer Cohen :tomer]

I guess these are the lines that needs to be changed. Am I right?

https://github.com/mozilla/pontoon/blob/fef0380170d6a653ff6f22d3bc0f87ac1e1da4c8/pontoon/base/static/js/translate.js#L414-L416

Comment 2

[Matjaz Horvat [:mathjazz]]

(In reply to Tomer Cohen :tomer from comment #1)
> I guess these are the lines that needs to be changed. Am I right?
> 
> https://github.com/mozilla/pontoon/blob/
> fef0380170d6a653ff6f22d3bc0f87ac1e1da4c8/pontoon/base/static/js/translate.
> js#L414-L416

Correct.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/addbf338ab7bb97457a63a4c03fd722c7efd79c0
Fix bug 1324936: Linkify Resource path (#592)

Comment 4

[Tomer Cohen :tomer]

Is it possible to link to resource@context instead of resource? This way, we won't lose the context while transferring. 

Use case: 
* Search for 'accesskey' in all-resources
* Select a random item and click on the resource link so you'd be transferred to the specified resource.

Expected result:
If the link would point to the resource#context (while still displayed as resource, i.e., <a href="$resource#$context">$resource</a>), the user would still see the same string, but on the resource. In case of searching for accesskeys, most of the times the label of the accesskey would be next to the accesskey item.

Comment 5

[Tomer Cohen :tomer]

(In reply to Tomer Cohen :tomer from comment #4)
> Use case: 
> * Search for 'accesskey' in all-resources
> * Select a random item and click on the resource link so you'd be
https://mozilla-pontoon-staging.herokuapp.com/he/firefox/all-resources/?search=accesskey&string=76028

Comment 6

[Jarek Śmiejczak [:jotes]]

:tomer

It's definitely possible :-) I'll create a next PR.

Comment 7

[Matjaz Horvat [:mathjazz]]

What would you consider a context? Search? Search + Filter? Search + Filter + String? Any of these is possible.

That said, I'm not sure if that's how most users would expect that link to work. If you click on the "Go" button, search & filter are reset and the first entity is selected. And the linked resource path is currently just a shortcut for this operation.