Closed Bug 1324972 Opened 3 years ago Closed 3 years ago
Failures in 2
59 bytes, text/x-review-board-request
It's in the DrawElements calls, because our index validation kicks in and panics when it sees 0xff, 0xffff, or 0xffffffff. We can just disable index validation for WebGL 2 drivers. D3D10+ means we don't need this validation, and likewise we shouldn't need it for modern GL drivers.
Comment on attachment 8820515 [details] Bug 1324972 (flattened) - Disable unnecessary manual index validation for WebGL 2. - https://reviewboard.mozilla.org/r/100006/#review100498 ::: dom/canvas/WebGLBuffer.cpp:222 (Diff revision 1) > + return false; > + > return mCache->BeenUsedWithMultipleTypes(); > } > > +//// r+ for fixing a nit. What does this line work for? If you want to add comment line, probably you should follow Ln 170.
Attachment #8820515 - Flags: review?(dmu) → review+
Comment on attachment 8820597 [details] Bug 1324972 - Catch ANGLE's zealous index-out-of-bounds INVALID_OPs. - https://reviewboard.mozilla.org/r/100096/#review100566
Attachment #8820597 - Flags: review?(dmu) → review+
Comment on attachment 8821800 [details] Bug 1324972 - ANGLE DrawElements validation is wrong. - https://reviewboard.mozilla.org/r/100922/#review101568 r = me if sending a PR to https://github.com/mozilla/angle
Attachment #8821800 - Flags: review?(dmu) → review+
Attachment #8820597 - Attachment is obsolete: true
Attachment #8821800 - Attachment is obsolete: true
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/eb4b2c6559b6 (flattened) - Disable unnecessary manual index validation for WebGL 2. - r=daoshengmu
Fixed upstream: https://github.com/google/angle/commit/92db6947
You need to log in before you can comment on or make changes to this bug.