Closed Bug 1324999 Opened 4 years ago Closed 4 years ago

Improve encapsulation of state objects of MDSM

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: jwwang, Unassigned)

References

Details

(Keywords: meta)

http://searchfox.org/mozilla-central/rev/cc2a84852bd4e6f6d8d4d5b17b8382bb5d005749/dom/media/MediaDecoderStateMachine.cpp#3153

It is a bad smell for MDSM to check the current state and decide what to do next. All such code patterns should change to virtual functions so we have a clear separation between mechanism code (MDSM) and policy code (state objects).
Depends on: 1325004
Depends on: 1325317
Depends on: 1325321
Depends on: 1325894
Depends on: 1325905
Depends on: 1326330
Depends on: 1326335
Depends on: 1328541
Depends on: 1328547
Depends on: 1328781
Depends on: 1328782
Depends on: 1328810
Depends on: 1328811
Depends on: 1328831
Depends on: 1328836
Depends on: 1329098
Depends on: 1329110
Depends on: 1329554
Keywords: meta
Depends on: 1329891
Depends on: 1329897
Depends on: 1330254
Depends on: 1330603
Depends on: 1330889
All dependency fixed.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.