1325001 - Firefox Assumes the "kind" of <track> tags

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[cyappleseed]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36
Firefox for Android

Steps to reproduce:

In a .html file when making a <video> you would normally have the option to assign a <track> tag FIGURE 1. this would be for video indexing,subtitling and descriptions and this can typicaly be differentiated by setting the kind (kind="subtitling" for example). In this case FIGURE 1. the kind="chapters"  so they should be no subtitling. 

FIGURE 1.
<video controls poster="/images/sample.gif">
   <source src="sample.mp4" type="video/mp4">
   <source src="sample.ogv" type="video/ogv">
   <track kind="chapters" src="sampleChapters.vtt" srclang="en">
</video>


Actual results:

In this case FIGURE 1. the kind="chapters" so there should be no subtitling. Then when executing the html Firefox assumes  vtt to be all the "kinds" of the track tag. So subtitling is showing up as well as indexing and description. Even when there are two vtt files FIGURE 2. assigned the first one is taking priority for all the roles

FIGURE 2.
<video controls poster="/images/sample.gif">
   <source src="sample.mp4" type="video/mp4">
   <source src="sample.ogv" type="video/ogv">
   <track kind="chapters" src="sampleChapters.vtt" srclang="en">
   <track kind="subtitles" src="sampleSubtitles_en.vtt" srclang="en">
</video>


Expected results:

What should happen is the vtt should be limited to what the "kind" it is set to so in this case only indexing or chapters should be populating.

Comment 1

[Benjamin Chen [:bechen]]

Sorry we miss the bug for a while.

Do you mean that firefox shows the "chapters content" as subtitle?
That's a bug I found in our codebase.

Comment 2

[cyappleseed]

I believe so "chapters content" or "Indexing".


Would Screenshots Help??

Comment 3

[Benjamin Chen [:bechen]]

Attachment: Bug 1325001 - TextTrackList::GetShowingCues should return cues whose kind is Subtitles or Captions.

We should only render the Subtitles/Captions cue on the screen. In addition, rename the activeCues to showingCues.
Because the meaning of "active" and "showing" are different. Showing means we can see the cue on the screen, active means the current playback time touches the cue.

Review commit: https://reviewboard.mozilla.org/r/141442/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141442/

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8869896 [details]
Bug 1325001 - TextTrackList::GetShowingCues should return cues whose kind is Subtitles or Captions.

https://reviewboard.mozilla.org/r/141442/#review145668

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf614473c436
TextTrackList::GetShowingCues should return cues whose kind is Subtitles or Captions. r=rillian

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bf614473c436