Switch ScreenOrientation to using the caller-type version of ResistFingerprinting

RESOLVED FIXED in Firefox 53

Status

()

Core
DOM
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(5 attachments, 1 obsolete attachment)

Found this while working on bug 1320801.  See in particular screen.mozOrientation.
Hmm.  Maybe it works out ok because we use the docshell.  Retitling bug.
Summary: Some ways of getting orientation don't properly resist fingerprinting → Switch ScreenOrientation to using the caller-type version of ResistFingerprinting
Created attachment 8820630 [details] [diff] [review]
part 1.  Remove some unused nsIDOMScreen function
Attachment #8820630 - Flags: review?(bkelly)
(Assignee)

Updated

8 months ago
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Created attachment 8820631 [details] [diff] [review]
part 2.  Switch ScreenOrientation's deviceType getter to use the caller-type version of ResistFingerprinting
Attachment #8820631 - Flags: review?(bkelly)
Created attachment 8820632 [details] [diff] [review]
part 3.  Switch ScreenOrientation's DeviceAngle getter to use the caller-type version of ResistFingerprinting
Attachment #8820632 - Flags: review?(bkelly)
Created attachment 8820633 [details] [diff] [review]
part 4.  Switch ScreenOrientation's type getter to use the caller-type version of ResistFingerprinting
Attachment #8820633 - Flags: review?(bkelly)
Created attachment 8820634 [details] [diff] [review]
part 5.  Switch ScreenOrientation's angle getter to use the caller-type version of ResistFingerprinting
Attachment #8820634 - Flags: review?(bkelly)
Created attachment 8820638 [details] [diff] [review]
part 2.  Switch ScreenOrientation's deviceType getter to use the caller-type version of ResistFingerprinting
Attachment #8820638 - Flags: review?(bkelly)
(Assignee)

Updated

8 months ago
Attachment #8820631 - Attachment is obsolete: true
Attachment #8820631 - Flags: review?(bkelly)

Updated

8 months ago
Attachment #8820630 - Flags: review?(bkelly) → review+

Updated

8 months ago
Attachment #8820638 - Flags: review?(bkelly) → review+

Updated

8 months ago
Attachment #8820632 - Flags: review?(bkelly) → review+

Updated

8 months ago
Attachment #8820633 - Flags: review?(bkelly) → review+

Updated

8 months ago
Attachment #8820634 - Flags: review?(bkelly) → review+

Comment 8

8 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c5fe9613c70
part 1.  Remove some unused nsIDOMScreen functions.  r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f22a651183c
part 2.  Switch ScreenOrientation's deviceType getter to use the caller-type version of ResistFingerprinting.  r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/657a726fddf4
part 3.  Switch ScreenOrientation's DeviceAngle getter to use the caller-type version of ResistFingerprinting.  r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b1626d7c6eb
part 4.  Switch ScreenOrientation's type getter to use the caller-type version of ResistFingerprinting.  r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/14d3d0bb1de9
part 5.  Switch ScreenOrientation's angle getter to use the caller-type version of ResistFingerprinting.  r=bkelly

Comment 9

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8c5fe9613c70
https://hg.mozilla.org/mozilla-central/rev/2f22a651183c
https://hg.mozilla.org/mozilla-central/rev/657a726fddf4
https://hg.mozilla.org/mozilla-central/rev/9b1626d7c6eb
https://hg.mozilla.org/mozilla-central/rev/14d3d0bb1de9
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.