1325073 - Make a shorter version for constructing error values of Result<V,E>

Status: RESOLVED FIXED

Description

[Nicolas B. Pierron [:nbp]]

To construct an error value today, we have to use either the constructor of the Result<V,E>, or to use the GenericErrorResult<E>.

In IonBuilder (Bug 1286505) we have multiple Ok types, but a single generic error type, in which case making such error is made verbose by the function

  mozilla::MakeGenericErrorResult

I suggest to rename this function to

  mozilla::Err

In order to follow the same naming as Rust code, and in the continuity of the Ok() constructor.

Comment 1

[Nicolas B. Pierron [:nbp]]

Created attachment 8820717 [details] [diff] [review]
Rename mozilla::MakeGenericErrorResult to mozilla::Err.

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8820717 [details] [diff] [review]
Rename mozilla::MakeGenericErrorResult to mozilla::Err.

Review of attachment 8820717 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/Ion.h
@@ +40,5 @@
>  
>  template <typename V>
>  using AbortReasonOr = mozilla::Result<V, AbortReason>;
>  using mozilla::Ok;
> +using mozilla::Err;

This should go before Ok for alphabetical purposes.

::: mfbt/tests/TestResult.cpp
@@ +6,5 @@
>  
>  #include "mozilla/Result.h"
>  
>  using mozilla::GenericErrorResult;
> +using mozilla::Err;

E before G, so move this one line earlier.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ec4fd0c06c9
Rename mozilla::MakeGenericErrorResult to mozilla::Err. r=Waldo

Comment 4

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/3ec4fd0c06c9