Space above tabs is 1px too big on Windows 10 (2px instead of 1px)

NEW
Unassigned

Status

()

Firefox
Theme
P3
normal
10 months ago
11 days ago

People

(Reporter: Will, Unassigned, NeedInfo)

Tracking

50 Branch
All
Windows 10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 months ago
Created attachment 8820804 [details]
freespace.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161208153507

Steps to reproduce:

this is slowly driving me nuts and I had to finally file it: using v50.1 stable on a Surface Pro 4, all settings are default. When Firefox is maximized, there is a pixel or 2 too much empty space above the focused tab! The GUI should be moved up 1 or 2 pixels. I know it's sounds silly but we shouldn't waste precious vertical space even if it's only 1 pixel and also it looks like firefox isn't FULLY maximized even though it is . I attached a screenshot

Updated

10 months ago
Component: Untriaged → Theme
I'm fairly sure this is intentional. Stephen?
Flags: needinfo?(shorlander)
(In reply to :Gijs Kruitbosch from comment #1)
> I'm fairly sure this is intentional. Stephen?

Yes. It's there to give a little buffer to maintain the tab shape outline against the tabstrip background. It was a little more obvious on Windows 7 where we had a roughly 2px border + shadow but it works on Windows 10 as well.
Flags: needinfo?(shorlander)
(Reporter)

Comment 3

10 months ago
I understand now. Would you consider reducing it to 1 instead of the current 2? (It looks like 3 on my computer but I could be wrong)

(In reply to Stephen Horlander [:shorlander] from comment #2)
> (In reply to :Gijs Kruitbosch from comment #1)
> > I'm fairly sure this is intentional. Stephen?
> 
> Yes. It's there to give a little buffer to maintain the tab shape outline
> against the tabstrip background. It was a little more obvious on Windows 7
> where we had a roughly 2px border + shadow but it works on Windows 10 as
> well.
Hm, seems there's a theme bug. I believe it should be 1 CSS pixel (which might then end up looking bigger on your hidpi screen, as you noted), but it looks to me like there's 2 right now (checked with screenshots on my lodpi machine). There's only 1 on e.g. Windows 7. That's just a bug, I think.

Off-hand, I suspect we're using a transparent border at the top of the tab and haven't taken its default 1px height into account here (tabs have borders on all other versions of Windows and on other OSes). But I haven't investigated in detail.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Unspecified → Windows 10
Priority: -- → P3
Hardware: Unspecified → All
Summary: there is a pixel or 2 of too much space above focused tab when Firefox for Windows 10 is maximized → Space above tabs is 1px too big on Windows 10 (2px instead of 1px)
(In reply to :Gijs (gone until 3 jan) from comment #4)
> Hm, seems there's a theme bug. I believe it should be 1 CSS pixel (which
> might then end up looking bigger on your hidpi screen, as you noted), but it
> looks to me like there's 2 right now (checked with screenshots on my lodpi
> machine). There's only 1 on e.g. Windows 7. That's just a bug, I think.

Eh, let's doublecheck Stephen agrees...
Flags: needinfo?(shorlander)
You need to log in before you can comment on or make changes to this bug.