1325129 - investigate support for caret-color property

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

bug 1063162 implements the caret-color CSS property. This bug is to investigate any work required by the Inspector in supporting this property and to track that work as it is done.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

Here's the intent to ship email: https://groups.google.com/d/msg/mozilla.dev.platform/lOpCwCMIWwo/nom3la3CEAAJ

Also there are a number of test HTML pages here: https://github.com/w3c/csswg-test/tree/master/css-ui-3

You can throw them into https://rawgit.com/ to test. e.g. https://rawgit.com/w3c/csswg-test/master/css-ui-3/caret-color-001.html

Comment 2

[Patrick Brosset <:pbro>]

Values of the 'caret-color' property displayed in the rule-view should have a color swatch displayed next to them just like values of the 'color' property.

iirc, color swatches appear next to colors automatically when options.supportsColor equals `true` in OutputParser.parseCssProperty [1].
The only way that it can be true is if the property (caret-color in this case) is defined as supporting the COLOR  or GRADIENT css types.
I think the mapping of properties and types comes from the CSS database [2], which uses DOMUtils.cssPropertySupportsType for this.

So, we need this platform API to be up to date for caret-color to appear just like any other colors in the rule-view.

[1] http://searchfox.org/mozilla-central/rev/ac40ca3ec39efe85bfb111274c10ee4ceea5bb7a/devtools/client/shared/output-parser.js#69
[2] http://searchfox.org/mozilla-central/source/devtools/server/actors/css-properties.js

Comment 3

[Tom Tromey :tromey]

I tried this today and we do get a color swatch in the rule view for the caret-color property.
If that's all that we wanted (I think so but I'm not certain), then this bug can be closed.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

Just tried it out, looks good!